From: Florian Fainelli <f.fainelli@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jaedon Shin <jaedon.shin@gmail.com>
Subject: Re: linux-next: Fixes tags need some work in the block tree
Date: Fri, 27 Dec 2019 13:51:49 -0800 [thread overview]
Message-ID: <e90eed94-3c56-3bc8-f118-f46f2dfe0571@gmail.com> (raw)
In-Reply-To: <3e6975e8-0509-c888-5b90-489ca0f40456@kernel.dk>
On 12/27/2019 12:44 PM, Jens Axboe wrote:
> On 12/27/19 1:39 PM, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>> On 12/27/19 1:27 PM, Florian Fainelli wrote:
>>>> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
>>>>>
>>>>> In commit
>>>>>
>>>>> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>>>>
>>>>> Fixes tags
>>>>>
>>>>> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>>>>> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>>>>
>>>>> have this problem:
>>>>>
>>>>> - Target SHA1s do not exist
>>>>>
>>>>> Perhaps you meant
>>>>>
>>>>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>>>>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
>>>>
>>>> Yes, those are the two that should have been used, the two commits were
>>>> extracted from a downstream tree where the upstream commits ended up
>>>> looking slightly different, my script does not (yet) rewrite those, Jens
>>>> would you want me to resubmit or can you rewrite the commit message in
>>>> place?
>>>
>>> It's too late unfortunately, Linus already pulled it. So we'll have to
>>> live with it, at least the commit titles are correct so it should be
>>> manageable.
>>
>> Unfortunately, even the titles are not correct, so they took me a
>> little time to find the correct commits :-( This means it will also
>> take the stable maintainers a bit of time.
>
> Yeah I see, the 2nd one is not. Gah, that really sucks. I'll let stable
> know.
>
> Florian, please ensure that future submissions have both the right titles
> and shas.
Definitively, very sorry about that and thank you both.
--
Florian
next prev parent reply other threads:[~2019-12-27 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 19:55 linux-next: Fixes tags need some work in the block tree Stephen Rothwell
2019-12-27 20:27 ` Florian Fainelli
2019-12-27 20:29 ` Jens Axboe
2019-12-27 20:39 ` Stephen Rothwell
2019-12-27 20:44 ` Jens Axboe
2019-12-27 21:51 ` Florian Fainelli [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-06 20:43 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e90eed94-3c56-3bc8-f118-f46f2dfe0571@gmail.com \
--to=f.fainelli@gmail.com \
--cc=axboe@kernel.dk \
--cc=jaedon.shin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).