From: Randy Dunlap <rdunlap@infradead.org>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Kees Cook <keescook@chromium.org>,
Juxin Gao <gaojuxin@loongson.cn>,
Xuefeng Li <lixuefeng@loongson.cn>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [next] mips-mt.c:233:19: error: conflicting types for 'mt_init'
Date: Mon, 7 Mar 2022 12:51:13 -0800 [thread overview]
Message-ID: <ea27ccf9-9ef2-f1db-815b-176b4ed1a907@infradead.org> (raw)
In-Reply-To: <20220307191537.jz6rho2vikdybpam@revolver>
On 3/7/22 11:15, Liam Howlett wrote:
> Hello Randy,
>
> I did address this when it occurred on the 24th [1]. I had looked at
> this and was thinking I would rename the maple tree function, but
> Matthew suggested renaming the mips function instead. I looked into the
> conflict and the arch/mips/kernel/mips-mt.c uses the mips_ prefix for
> almost all of the functions. So I generated a patch on my tree for
> next-20220225 which fixes the issue by renaming the mips side of things.
> Please see 51e773764d11 for the very small rename.
>
> [1]
> https://lore.kernel.org/linux-mm/202202241817.MXoE0NcM-lkp@intel.com/
>
> Thanks,
> Liam
OK, sounds good. Thanks.
>
> * Randy Dunlap <rdunlap@infradead.org> [220305 22:50]:
>> Hi Liam,
>>
>> Would you consider renaming maple tree's "mt_init()" function to
>> maple_tree_init() or mtree_init() or something that does not
>> conflict with the mt_init() function in arch/mips/ so that
>> these build errors don't happen?
>>
>> thanks.
>>
>> On 2/24/22 23:09, Naresh Kamboju wrote:
>>> [Please ignore this email if it is already reported]
>>>
>>> Linux next-20220224 arch mips build errors / warnings noticed [1].
>>>
>>> Build configs:
>>> - mips-gcc-8-malta_defconfig
>>> - mips-gcc-10-malta_defconfig
>>> - mips-gcc-8-defconfig
>>> - mips-gcc-10-defconfig
>>>
>>> metadata:
>>> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>>> git_sha: 44948bd49d878dad6c9707e34f4a06df73c3a800
>>> git_short_log: 44948bd49d87 (\Add linux-next specific files for 20220224\)
>>> kconfig: defconfig
>>> target_arch: mips
>>> toolchain: gcc-10
>>>
>>>
>>> Build errors / warnings:
>>>
>>> arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'
>>> 233 | static int __init mt_init(void)
>>> | ^~~~~~~
>>> In file included from include/linux/mm_types.h:12,
>>> from include/linux/mmzone.h:21,
>>> from include/linux/gfp.h:6,
>>> from include/linux/radix-tree.h:12,
>>> from include/linux/idr.h:15,
>>> from include/linux/kernfs.h:12,
>>> from include/linux/sysfs.h:16,
>>> from include/linux/kobject.h:20,
>>> from include/linux/energy_model.h:7,
>>> from include/linux/device.h:16,
>>> from arch/mips/kernel/mips-mt.c:7:
>>> include/linux/maple_tree.h:589:20: note: previous definition of
>>> 'mt_init' was here
>>> 589 | static inline void mt_init(struct maple_tree *mt)
>>> | ^~~~~~~
>>> make[3]: *** [scripts/Makefile.build:288: arch/mips/kernel/mips-mt.o] Error 1
>>>
>>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>>
>>> Steps to reproduce:
>>> ------------------
>>> # To install tuxmake on your system globally:
>>> # sudo pip3 install -U tuxmake
>>>
>>> tuxmake --runtime podman --target-arch mips --toolchain gcc-10
>>> --kconfig defconfig
>>>
>>> --
>>>
>>> [1] https://builds.tuxbuild.com/25aFF2X7uoyebURaYzNHW9FVEmN/
>>
>> --
>> ~Randy
--
~Randy
prev parent reply other threads:[~2022-03-07 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 7:09 [next] mips-mt.c:233:19: error: conflicting types for 'mt_init' Naresh Kamboju
2022-03-06 3:49 ` Randy Dunlap
2022-03-07 19:15 ` Liam Howlett
2022-03-07 20:51 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea27ccf9-9ef2-f1db-815b-176b4ed1a907@infradead.org \
--to=rdunlap@infradead.org \
--cc=gaojuxin@loongson.cn \
--cc=keescook@chromium.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=tsbogend@alpha.franken.de \
--cc=willy@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).