From: Bart Van Assche <bvanassche@acm.org>
To: Julian Wiedmann <jwi@linux.ibm.com>,
Steffen Maier <maier@linux.ibm.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com,
linux-scsi@vger.kernel.org
Cc: gregkh@linuxfoundation.org, bblock@linux.ibm.com,
linux-next@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v2] scsi: core: Fix early registration of sysfs attributes for scsi_device
Date: Mon, 25 Oct 2021 09:00:05 -0700 [thread overview]
Message-ID: <eaa30030-120a-8e72-82d9-873e992007fd@acm.org> (raw)
In-Reply-To: <2f5e5d18-7ba9-10f6-1855-84546172b473@linux.ibm.com>
On 10/25/21 2:23 AM, Julian Wiedmann wrote:
> On 25.10.21 00:16, Steffen Maier wrote:
>> void scsi_sysfs_device_initialize(struct scsi_device *sdev)
>> {
>> - int i, j = 0;
>> + int i = 0;
>> unsigned long flags;
>> struct Scsi_Host *shost = sdev->host;
>> struct scsi_host_template *hostt = shost->hostt;
>> @@ -1583,15 +1583,15 @@ void scsi_sysfs_device_initialize(struct scsi_device *sdev)
>> scsi_enable_async_suspend(&sdev->sdev_gendev);
>> dev_set_name(&sdev->sdev_gendev, "%d:%d:%d:%llu",
>> sdev->host->host_no, sdev->channel, sdev->id, sdev->lun);
>> - sdev->gendev_attr_groups[j++] = &scsi_sdev_attr_group;
>> + sdev->sdev_gendev.groups = sdev->gendev_attr_groups;
>> if (hostt->sdev_groups) {
>> for (i = 0; hostt->sdev_groups[i] &&
>> - j < ARRAY_SIZE(sdev->gendev_attr_groups);
>> - i++, j++) {
>> - sdev->gendev_attr_groups[j] = hostt->sdev_groups[i];
>> + i < ARRAY_SIZE(sdev->gendev_attr_groups);
>> + i++) {
>> + sdev->gendev_attr_groups[i] = hostt->sdev_groups[i];
>> }
>> }
>> - WARN_ON_ONCE(j >= ARRAY_SIZE(sdev->gendev_attr_groups));
>> + WARN_ON_ONCE(i >= ARRAY_SIZE(sdev->gendev_attr_groups));
>>
>
> Can't we simply assign the hostt->sdev_groups now, without the additional
> indirection?
>
> sdev->sdev_gendev.groups = hostt->sdev_groups;
Hi Steffen,
Please let me know if you wouldn't have the time to integrate the
approach mentioned above in a new version of your patch.
Thanks,
Bart.
next prev parent reply other threads:[~2021-10-25 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211012233558.4066756-1-bvanassche@acm.org>
[not found] ` <163478764102.7011.9375895285870786953.b4-ty@oracle.com>
2021-10-23 20:54 ` Missing driver-specific sysfs attributes of scsi_device [was: Re: [PATCH v4 00/46] Register SCSI sysfs attributes earlier] Steffen Maier
2021-10-24 0:39 ` Steffen Maier
2021-10-24 2:55 ` Bart Van Assche
2021-10-24 11:18 ` [PATCH] scsi: core: Fix early registration of sysfs attributes for scsi_device Steffen Maier
2021-10-24 21:25 ` Bart Van Assche
2021-10-24 22:16 ` [PATCH v2] " Steffen Maier
2021-10-25 9:23 ` Julian Wiedmann
2021-10-25 16:00 ` Bart Van Assche [this message]
2021-10-26 1:42 ` [PATCH v3] " Steffen Maier
2021-10-26 10:00 ` Benjamin Block
2021-10-26 21:48 ` Bart Van Assche
2021-10-29 17:55 ` Benjamin Block
2021-10-26 18:31 ` Bart Van Assche
2021-10-29 17:56 ` Benjamin Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa30030-120a-8e72-82d9-873e992007fd@acm.org \
--to=bvanassche@acm.org \
--cc=bblock@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).