From: Jie Deng <jie.deng@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Conghui Chen <conghui.chen@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the i2c tree
Date: Wed, 18 Aug 2021 15:13:55 +0800 [thread overview]
Message-ID: <eaabdd90-9838-8ff2-594c-1088bdd130a1@intel.com> (raw)
In-Reply-To: <20210818170418.5e03390b@canb.auug.org.au>
On 2021/8/18 15:04, Stephen Rothwell wrote:
> Hi Jie,
>
> On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@intel.com> wrote:
>> On 2021/8/18 14:29, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the i2c tree, today's linux-next build (powerpc
>>> allyesconfig) produced this warning:
>>>
>>> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
>>> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
>>> 208 | struct device *pdev = vdev->dev.parent;
>>> | ^~~~
>>>
>>> Introduced by commit
>>>
>>> 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>>
> When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.
Thanks Stephen. I will send an additional patch to fix it.
next prev parent reply other threads:[~2021-08-18 7:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:29 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2021-08-18 6:54 ` Jie Deng
2021-08-18 7:04 ` Stephen Rothwell
2021-08-18 7:13 ` Jie Deng [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-02 3:21 Stephen Rothwell
2019-08-02 6:04 ` Uwe Kleine-König
2019-06-11 0:25 Stephen Rothwell
2019-06-12 8:19 ` Wolfram Sang
2019-06-12 11:02 ` Mauro Carvalho Chehab
2019-06-12 11:09 ` Wolfram Sang
2019-06-12 11:48 ` Mauro Carvalho Chehab
2019-06-12 12:04 ` Wolfram Sang
2019-06-12 12:32 ` Mauro Carvalho Chehab
2019-06-12 13:15 ` Stephen Rothwell
2019-06-12 13:24 ` Wolfram Sang
2017-06-05 1:11 Stephen Rothwell
2017-06-15 1:34 ` Stephen Rothwell
2017-06-15 7:02 ` Wolfram Sang
2017-06-15 8:48 ` Stephen Rothwell
2014-03-06 2:50 Stephen Rothwell
2010-03-28 23:54 Stephen Rothwell
2010-03-29 13:21 ` Jean Delvare
2010-03-29 14:12 ` Stephen Rothwell
2010-02-17 0:38 Stephen Rothwell
2010-02-17 8:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaabdd90-9838-8ff2-594c-1088bdd130a1@intel.com \
--to=jie.deng@intel.com \
--cc=conghui.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).