linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Dave Airlie <airlied@linux.ie>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Swapnil Jakhade <sjakhade@cadence.com>,
	Jyri Sarha <jsarha@ti.com>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	Yuti Amonkar <yamonkar@cadence.com>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the drm tree
Date: Wed, 23 Sep 2020 09:27:53 +0300	[thread overview]
Message-ID: <f4581178-77b1-758b-84e5-4810ed0f46d1@ti.com> (raw)
In-Reply-To: <20200923133601.293b4fe6@canb.auug.org.au>

Hi Stephen,

On 23/09/2020 06:36, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_fw_activate':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:751:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>   751 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_attach':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:1692:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  1692 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c: In function 'cdns_mhdp_bridge_hpd_enable':
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2125:10: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551613' to '4294967293' [-Woverflow]
>  2125 |   writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
> 
> Introduced by commit
> 
>   fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")
> 

Thanks. I think we can just do:

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 621ebdbff8a3..d0c65610ebb5 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -748,7 +748,7 @@ static int cdns_mhdp_fw_activate(const struct firmware *fw,
 	 * bridge should already be detached.
 	 */
 	if (mhdp->bridge_attached)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 
 	spin_unlock(&mhdp->start_lock);
@@ -1689,7 +1689,7 @@ static int cdns_mhdp_attach(struct drm_bridge *bridge,
 
 	/* Enable SW event interrupts */
 	if (hw_ready)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 
 	return 0;
@@ -2122,7 +2122,7 @@ static void cdns_mhdp_bridge_hpd_enable(struct drm_bridge *bridge)
 
 	/* Enable SW event interrupts */
 	if (mhdp->bridge_attached)
-		writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
+		writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT,
 		       mhdp->regs + CDNS_APB_INT_MASK);
 }

I'll send a patch.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-09-23  6:28 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  3:36 linux-next: build warning after merge of the drm tree Stephen Rothwell
2020-09-23  6:27 ` Tomi Valkeinen [this message]
2020-10-01  9:47 ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-02-07  6:17 Stephen Rothwell
2024-02-07 14:19 ` Rodrigo Vivi
2024-01-05  6:47 Stephen Rothwell
2024-01-25  0:33 ` Stephen Rothwell
2024-01-26  8:48   ` Thomas Hellström
2024-01-02  0:12 Stephen Rothwell
2024-01-03  1:19 ` Stephen Rothwell
2024-01-03  1:27   ` Stephen Rothwell
2024-01-04 16:52     ` Jani Nikula
2023-11-24  2:25 Stephen Rothwell
2023-11-24 12:35 ` Donald Robson
2023-11-24  2:23 Stephen Rothwell
2023-11-24  2:17 Stephen Rothwell
2023-04-11  6:02 Stephen Rothwell
2023-04-11  9:48 ` Andi Shyti
2023-04-11  6:01 Stephen Rothwell
2023-03-30  3:28 Stephen Rothwell
2023-03-30 14:28 ` Rob Clark
2023-07-11 23:17   ` Stephen Rothwell
2023-07-24  3:50     ` Stephen Rothwell
2023-02-03  2:46 Stephen Rothwell
2023-02-03 12:32 ` Gustavo Sousa
2023-01-05  3:43 Stephen Rothwell
2023-01-05  3:21 Stephen Rothwell
2023-01-05  3:17 Stephen Rothwell
2022-11-07  3:29 Stephen Rothwell
2022-11-07 20:31 ` John Harrison
2022-02-02  4:10 Stephen Rothwell
2022-03-02  1:32 ` Stephen Rothwell
2022-02-02  4:02 Stephen Rothwell
2022-02-02  4:03 ` Stephen Rothwell
2022-02-02  8:38   ` Hans de Goede
2022-02-04 19:29     ` Rajat Jain
2022-03-02  1:34     ` Stephen Rothwell
2022-03-02 10:32       ` Hans de Goede
2022-03-02 11:38         ` Stephen Rothwell
2021-04-01  7:19 Stephen Rothwell
2021-04-21  6:28 ` Stephen Rothwell
2021-03-17  7:42 Stephen Rothwell
2021-03-17  2:53 Stephen Rothwell
2021-01-22  0:59 Stephen Rothwell
2021-01-22  7:17 ` Daniel Vetter
2021-01-22  7:29   ` Stephen Rothwell
2021-01-22  8:40     ` Daniel Vetter
2021-10-27 12:12       ` Joonas Lahtinen
2021-10-27 20:51         ` Stephen Rothwell
2021-10-28  9:16           ` Joonas Lahtinen
2021-02-01  1:55 ` Stephen Rothwell
2020-11-05  7:02 Stephen Rothwell
2020-11-16  0:01 ` Stephen Rothwell
2020-05-11  3:47 Stephen Rothwell
2020-05-11  4:04 ` Randy Dunlap
2019-02-01  0:53 Stephen Rothwell
2018-06-25  4:22 Stephen Rothwell
2018-06-25  4:22 ` Stephen Rothwell
2018-02-18 23:18 Stephen Rothwell
2018-03-02  1:49 ` Stephen Rothwell
2017-12-04  0:30 Stephen Rothwell
2017-12-04  0:57 ` Dave Airlie
2017-06-19  1:40 Stephen Rothwell
2017-05-19  2:10 Stephen Rothwell
2017-05-03 22:33 Stephen Rothwell
     [not found] ` <tencent_62AF37B85899E2EA593CCE3B@qq.com>
2017-05-04  1:42   ` Stephen Rothwell
2015-06-04 12:31 Stephen Rothwell
2015-05-20  6:54 Stephen Rothwell
2015-05-20 11:49 ` Sergey Senozhatsky
2015-05-20  6:31 Stephen Rothwell
2015-05-20 19:51 ` Russell King - ARM Linux
2013-06-28  3:30 Stephen Rothwell
2013-06-28  3:33 ` Dave Airlie
2013-04-19  5:50 Stephen Rothwell
2012-05-08  5:08 Stephen Rothwell
2011-11-28  2:41 Stephen Rothwell
2011-11-28  2:36 Stephen Rothwell
2011-05-12  2:14 Stephen Rothwell
2010-03-01  7:14 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4581178-77b1-758b-84e5-4810ed0f46d1@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=quentin.schulz@free-electrons.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sjakhade@cadence.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).