Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the net-next tree
Date: Tue, 13 Mar 2018 15:28:16 -0500
Message-ID: <f69bb910-23c8-0354-d78b-db097194048d@embeddedor.com> (raw)
In-Reply-To: <20180313.113313.629581257230548483.davem@davemloft.net>



On 03/13/2018 10:33 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Tue, 13 Mar 2018 06:46:24 -0500
> 
>> Hi Stephen,
>>
>> On 03/13/2018 01:11 AM, Stephen Rothwell wrote:
>>> Hi all,
>>> After merging the net-next tree, today's linux-next build (sparc
>>> defconfig) produced this warning:
>>> net/core/pktgen.c: In function 'pktgen_if_write':
>>> net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is
>>> larger than 1024 bytes [-Wframe-larger-than=]
>>>    }
>>>    ^
>>> Introduced by commit
>>>     35951393bbff ("pktgen: Remove VLA usage")
>>>
>>
>> Thanks for the report.
>>
>> David:
>>
>> If this code is not going to be executed very often [1], then I think
>> it is safe to use dynamic memory allocation instead, as this is not
>> going to impact the performance.
>>
>> What do you think?
>>
>> [1] https://lkml.org/lkml/2018/3/9/630
> 
> Sure, that works.
> 
> It is only invoked when pktgen configuration changes are made.
> 

OK. I'll send a new patch for this.

Thanks
--
Gustavo

  reply index

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13  6:11 Stephen Rothwell
2018-03-13 11:46 ` Gustavo A. R. Silva
2018-03-13 15:33   ` David Miller
2018-03-13 20:28     ` Gustavo A. R. Silva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-21  7:34 Stephen Rothwell
2019-11-11  1:39 Stephen Rothwell
2019-11-11  1:45 ` Eric Dumazet
2019-11-11  1:19 Stephen Rothwell
2019-11-11 10:24 ` Russell King - ARM Linux admin
2019-10-07 22:42 Stephen Rothwell
2019-10-09 12:24 ` David Howells
2019-07-08  3:25 Stephen Rothwell
2019-05-23 23:47 Stephen Rothwell
2019-04-23  1:32 Stephen Rothwell
2019-04-16  1:20 Stephen Rothwell
2019-04-16 10:03 ` John Hurley
2019-03-21 23:05 Stephen Rothwell
2019-03-21 23:10 ` Florian Fainelli
2019-02-22  1:06 Stephen Rothwell
2019-02-22  1:10 ` Florian Fainelli
2019-02-13  0:51 Stephen Rothwell
2019-02-13  0:58 ` Florian Fainelli
2019-02-13  0:49 Stephen Rothwell
2019-02-13  0:57 ` Florian Fainelli
2019-02-03 23:44 Stephen Rothwell
2019-02-04  4:26 ` David Miller
2019-02-04  4:32   ` Stephen Rothwell
2018-11-29  0:24 Stephen Rothwell
2018-12-19  2:42 ` Stephen Rothwell
2018-12-19  3:07   ` Gustavo A. R. Silva
2018-12-19  5:37     ` Stephen Rothwell
2018-07-19  2:04 Stephen Rothwell
2018-07-19  3:52 ` Guenter Roeck
2018-07-19  5:29   ` Stephen Rothwell
2018-07-19 13:49     ` Guenter Roeck
2018-07-19 22:09       ` Stephen Rothwell
2018-07-19 22:35         ` Guenter Roeck
2018-07-19 23:19           ` Masahiro Yamada
2018-07-19 23:37             ` Guenter Roeck
2018-08-14  7:05             ` Masahiro Yamada
2018-08-14 13:28               ` Guenter Roeck
2018-07-20  1:06           ` Stephen Rothwell
2018-07-19  1:40 Stephen Rothwell
2018-07-20 20:31 ` Linus Walleij
2018-07-05 23:56 Stephen Rothwell
2018-07-07 11:30 ` David Miller
2018-07-07 12:03   ` Stephen Rothwell
2018-05-29  3:10 Stephen Rothwell
2018-01-18  1:20 Stephen Rothwell
2017-12-04  0:02 Stephen Rothwell
2017-12-04  6:33 ` Heiner Kallweit
2017-12-04 18:21 ` David Miller
2017-11-15  5:01 Stephen Rothwell
2016-12-09  0:34 Stephen Rothwell
2016-11-16  0:36 Stephen Rothwell
2016-11-16  0:56 ` Martin KaFai Lau
2016-07-27  6:15 Stephen Rothwell
2016-07-27  6:19 ` David Miller
2016-07-27  6:35   ` Stephen Rothwell
2016-07-27  6:45     ` Iyappan Subramanian
2016-07-11  6:13 Stephen Rothwell
2016-07-11  8:16 ` Simon Horman
2016-07-04  3:15 Stephen Rothwell
2016-07-04  5:19 ` Jason Wang
2016-02-15  2:09 Stephen Rothwell
2016-02-15  8:01 ` Nikolay Borisov
2014-05-15  6:47 Stephen Rothwell
2014-05-15 17:39 ` Cong Wang
2014-05-15 17:43   ` David Miller
2014-05-15 18:36     ` Cong Wang
2014-01-06  4:53 Stephen Rothwell
2013-08-21  9:10 Stephen Rothwell
2013-08-21 18:15 ` David Miller
2013-02-18  6:00 Stephen Rothwell
2012-04-23  6:54 Stephen Rothwell
2012-04-23  7:22 ` David Miller

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f69bb910-23c8-0354-d78b-db097194048d@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git