From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DFA3C43334 for ; Wed, 22 Jun 2022 23:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233252AbiFVXor (ORCPT ); Wed, 22 Jun 2022 19:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiFVXor (ORCPT ); Wed, 22 Jun 2022 19:44:47 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E75C42A17 for ; Wed, 22 Jun 2022 16:44:46 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d5so16677512plo.12 for ; Wed, 22 Jun 2022 16:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=xiuf6zzvbLG03UYs0C2KLwj/eVIRqceMt7/BlzFnYGs=; b=xg+bSaA4gWWCgUv2DixZs6U6w9neQ3CWRdkRAs7h7X8ylApaGxfOBVIYZHibDzA0BO qwwctctan+VZXqN+VpninBE7FM0Mwa2fmYOmg+GDLRWiVGXjWktKj6Nk5DMvSg3R3FBJ uueM3ZRs+Y6MptlF/jEk4fOA/lpGOYb+HNjx3210xZu0FDVkMYI8iNyUAbPapoSas5WO 5JiQd0jeov/ucQRwrOIToeDPpZQQ0kqZt2pqelfTChiW0Pnwg8sAL2AissCoyUljQwfF cEdS+6rx95FbvJwSetOHDT3zgMtj3djbS5bDsL9R2MPXQy8DVnr64Wf1ZsqccpxpGb2P 62tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xiuf6zzvbLG03UYs0C2KLwj/eVIRqceMt7/BlzFnYGs=; b=dPwXQfGYjJrkyWwaGVnQB0AVwzJZd1hgrvnFsF/auflFbQmGAH3EpD71cdCy9PXVdY JFigijwOj6VTu5kA1/2U8cRwk0AuwRhbyXQT3J1YVtOG2Bjij5wIMi1X8XG5umqO+ulI fZz5D3xYESymfcbERXBhPxsiIh1Pq6oL7OrgubHennK6NT51W5NMOFWs5uhlpM7KynUb 1vr+C2jKvIQAUuu8lkhEscmFlaf0ubHAnIBgNQe/ytPpMVE1EQTKOKMYKKZyBBUJFE15 j1K1qTkr0wapbRFhUO1g8+7lMF9mQne6oK8ZreQqUtMV/p7PrahFY25JQTEUJYsy4+Kr /SQw== X-Gm-Message-State: AJIora/94FOLlPcwWLjBFyyVBjZ4cTUJNVPygg9BwQkDqXQRrJKOL/Qg z26IDCfmx7wuFmCpK31LpBoiNQ== X-Google-Smtp-Source: AGRyM1uilk/Jr0x+syRpFZ/nF+4NI/OGSgvao9e50J8tXM/WSqNrc24QNGuHDvCaqAtgKFS0vAZM3w== X-Received: by 2002:a17:90b:354c:b0:1ec:9ef2:8a0e with SMTP id lt12-20020a17090b354c00b001ec9ef28a0emr936394pjb.72.1655941485638; Wed, 22 Jun 2022 16:44:45 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id md17-20020a17090b23d100b001e2f383110bsm357045pjb.11.2022.06.22.16.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 16:44:45 -0700 (PDT) Message-ID: Date: Wed, 22 Jun 2022 17:44:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: linux-next: Fixes tag needs some work in the block tree Content-Language: en-US To: Stephen Rothwell Cc: Dylan Yudaken , Linux Kernel Mailing List , Linux Next Mailing List References: <20220623092143.2b9d2e7e@canb.auug.org.au> From: Jens Axboe In-Reply-To: <20220623092143.2b9d2e7e@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 6/22/22 5:21 PM, Stephen Rothwell wrote: > Hi all, > > In commit > > 1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of TP_printk") > > Fixes tag > > Fixes: 033b87d2 ("io_uring: use the text representation of ops in trace") > > has these problem(s): > > - SHA1 should be at least 12 digits long > This can be fixed for the future by setting core.abbrev to 12 (or > more) or (for git v2.11 or later) just making sure it is not set > (or set to "auto"). I'll rebase on -rc4 anyway, I'll fix thie one up. Dylan, here's what I use for adding Fixes tags: [pretty] fixes = Fixes: %h (\"%s\") and then I just do: git fixes 033b87d2 Fixes: 033b87d24f72 ("io_uring: use the text representation of ops in trace") to generate it. -- Jens Axboe