linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, linux-hams@vger.kernel.org,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: linux-next: Tree for Apr 23 (ax.25 sysctl)
Date: Mon, 23 Apr 2012 17:16:56 -0700	[thread overview]
Message-ID: <m1vckqrnk7.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4F95828A.8050403@xenotime.net> (Randy Dunlap's message of "Mon, 23 Apr 2012 09:25:46 -0700")

Randy Dunlap <rdunlap@xenotime.net> writes:

> On 04/23/2012 12:07 AM, Stephen Rothwell wrote:
>
>> Hi all,
>> 
>> Changes since 20120420:
>
>
>
> include/net/ax25.h:447:75: error: expected ';' before '}' token
>
>
> static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0 };
> static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {};
>
> Is this from Eric B.'s sysctl patches?

Sort of.  I made the function per device and return 0.

I missed the inner ';' when I made the change.  The outer '};' has
been there for years and has been weird but harmless.

Patch to fix it in a moment.

Eric


> First function:  move ';' inside braces.
> Second function:  drop the ';'.

  reply	other threads:[~2012-04-24  0:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  7:07 linux-next: Tree for Apr 23 Stephen Rothwell
2012-04-23 16:25 ` linux-next: Tree for Apr 23 (ax.25 sysctl) Randy Dunlap
2012-04-24  0:16   ` Eric W. Biederman [this message]
2012-04-24  0:23   ` [PATCH] net ax25: Fix the build when sysctl support is disabled Eric W. Biederman
2012-04-24  0:25   ` Eric W. Biederman
2012-04-24  1:28     ` Randy Dunlap
2012-04-24  2:15       ` David Miller
2012-04-23 16:38 ` linux-next: Tree for Apr 23 (phonet sysctl) Randy Dunlap
2012-04-23 22:13   ` [PATCH] net sysctl: Add place holder functions for when sysctl support is compiled out of the kernel Eric W. Biederman
2012-04-23 22:38     ` Randy Dunlap
2012-04-23 23:24       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1vckqrnk7.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).