Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	yash.shah@sifive.com
Subject: Re: linux-next: build failure after merge of the net-next tree
Date: Sun, 23 Jun 2019 20:59:46 -0700 (PDT)
Message-ID: <mhng-24035d0e-a382-4a48-89eb-eb00213fca7e@palmer-si-x1e> (raw)
In-Reply-To: <20190624131245.359e59a4@canb.auug.org.au>

On Sun, 23 Jun 2019 20:12:45 PDT (-0700), Stephen Rothwell wrote:
> Hi all,
>
> On Thu, 20 Jun 2019 19:13:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the net-next tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>> 
>> drivers/net/ethernet/cadence/macb_main.c:48:16: error: field 'hw' has incomplete type
>>   struct clk_hw hw;
>>                 ^~
>> drivers/net/ethernet/cadence/macb_main.c:4003:21: error: variable 'fu540_c000_ops' has initializer but incomplete type
>>  static const struct clk_ops fu540_c000_ops = {
>>                      ^~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4004:3: error: 'const struct clk_ops' has no member named 'recalc_rate'
>>   .recalc_rate = fu540_macb_tx_recalc_rate,
>>    ^~~~~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4004:17: warning: excess elements in struct initializer
>>   .recalc_rate = fu540_macb_tx_recalc_rate,
>>                  ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4004:17: note: (near initialization for 'fu540_c000_ops')
>> drivers/net/ethernet/cadence/macb_main.c:4005:3: error: 'const struct clk_ops' has no member named 'round_rate'
>>   .round_rate = fu540_macb_tx_round_rate,
>>    ^~~~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4005:16: warning: excess elements in struct initializer
>>   .round_rate = fu540_macb_tx_round_rate,
>>                 ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4005:16: note: (near initialization for 'fu540_c000_ops')
>> drivers/net/ethernet/cadence/macb_main.c:4006:3: error: 'const struct clk_ops' has no member named 'set_rate'
>>   .set_rate = fu540_macb_tx_set_rate,
>>    ^~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4006:14: warning: excess elements in struct initializer
>>   .set_rate = fu540_macb_tx_set_rate,
>>               ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/cadence/macb_main.c:4006:14: note: (near initialization for 'fu540_c000_ops')
>> drivers/net/ethernet/cadence/macb_main.c: In function 'fu540_c000_clk_init':
>> drivers/net/ethernet/cadence/macb_main.c:4013:23: error: storage size of 'init' isn't known
>>   struct clk_init_data init;
>>                        ^~~~
>> drivers/net/ethernet/cadence/macb_main.c:4032:12: error: implicit declaration of function 'clk_register'; did you mean 'sock_register'? [-Werror=implicit-function-declaration]
>>   *tx_clk = clk_register(NULL, &mgmt->hw);
>>             ^~~~~~~~~~~~
>>             sock_register
>> drivers/net/ethernet/cadence/macb_main.c:4013:23: warning: unused variable 'init' [-Wunused-variable]
>>   struct clk_init_data init;
>>                        ^~~~
>> drivers/net/ethernet/cadence/macb_main.c: In function 'macb_probe':
>> drivers/net/ethernet/cadence/macb_main.c:4366:2: error: implicit declaration of function 'clk_unregister'; did you mean 'sock_unregister'? [-Werror=implicit-function-declaration]
>>   clk_unregister(tx_clk);
>>   ^~~~~~~~~~~~~~
>>   sock_unregister
>> drivers/net/ethernet/cadence/macb_main.c: At top level:
>> drivers/net/ethernet/cadence/macb_main.c:4003:29: error: storage size of 'fu540_c000_ops' isn't known
>>  static const struct clk_ops fu540_c000_ops = {
>>                              ^~~~~~~~~~~~~~
>> 
>> Caused by commit
>> 
>>   c218ad559020 ("macb: Add support for SiFive FU540-C000")
>> 
>> CONFIG_COMMON_CLK is not set for this build.
>> 
>> I have reverted that commit for today.
>
> I am still reverting that commit.  Has this problem been fixed in some
> subtle way?

I don't think so.  I'm assuming something like this is necessary

diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index 1766697c9c5a..d13db9e9c818 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -23,6 +23,7 @@ config MACB
        tristate "Cadence MACB/GEM support"
        depends on HAS_DMA
        select PHYLIB
+       depends on COMMON_CLK
        ---help---
          The Cadence MACB ethernet interface is found on many Atmel AT32 and
          AT91 parts.  This driver also supports the Cadence GEM (Gigabit
@@ -42,7 +43,7 @@ config MACB_USE_HWSTAMP

 config MACB_PCI
        tristate "Cadence PCI MACB/GEM support"
-       depends on MACB && PCI && COMMON_CLK
+       depends on MACB && PCI
        ---help---
          This is PCI wrapper for MACB driver.

at a minimum, though it may be saner to #ifdef support for the SiFive clock
driver as that's only useful on some systems.  Assuming I can reproduce the
build failure (which shouldn't be too hard), I'll send out a patch that adds a
Kconfig for the FU540 clock driver to avoid adding a COMMON_CLK dependency for
all MACB systems.

  reply index

Thread overview: 244+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  9:13 Stephen Rothwell
2019-06-24  3:12 ` Stephen Rothwell
2019-06-24  3:59   ` Palmer Dabbelt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-05  8:53 Stephen Rothwell
2019-11-05 13:50 ` Andrew Lunn
2019-11-05 14:22   ` Stephen Rothwell
2019-09-04  6:00 Stephen Rothwell
2019-09-04  6:18 ` Masahiro Yamada
2019-09-05 19:26   ` Andrii Nakryiko
2019-09-06  2:52     ` Masahiro Yamada
2019-09-06  9:02       ` Andrii Nakryiko
2019-09-04  8:18 ` Andrii Nakryiko
2019-08-29 10:05 Stephen Rothwell
2019-08-30 21:35 ` David Miller
2019-07-25  9:37 Stephen Rothwell
2019-07-11 11:52 Jason Gunthorpe
2019-07-09  3:56 Stephen Rothwell
2019-07-09  6:43 ` Leon Romanovsky
2019-07-10  4:31   ` Stephen Rothwell
2019-07-10  5:20     ` Leon Romanovsky
2019-07-10 17:52   ` Jason Gunthorpe
2019-07-11  1:50     ` Stephen Rothwell
2019-07-11  2:26       ` Jason Gunthorpe
2019-07-11  3:13         ` Stephen Rothwell
2019-07-11  3:16           ` Stephen Rothwell
2019-07-11  3:27             ` Stephen Rothwell
2019-07-11  5:40             ` Leon Romanovsky
2019-07-11  8:00   ` Bernard Metzler
2019-07-11 12:29     ` Bernard Metzler
2019-07-11 14:33       ` Jason Gunthorpe
2019-07-12  1:45         ` Stephen Rothwell
2019-07-12 15:21           ` Jason Gunthorpe
2019-06-19  3:23 Stephen Rothwell
2019-06-19  4:02 ` Masahiro Yamada
2019-06-19  4:14   ` Masahiro Yamada
2019-06-19  8:50     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 13:46     ` David Miller
2019-06-19 14:13 ` David Miller
2019-06-19 15:09   ` Kevin 'ldir' Darbyshire-Bryant
2019-06-19 16:11     ` Kevin 'ldir' Darbyshire-Bryant
2019-06-11  8:26 Stephen Rothwell
2019-05-31  0:35 Stephen Rothwell
2019-04-23  7:25 Stephen Rothwell
2019-04-24  1:36 ` David Miller
2019-02-04  4:34 Stephen Rothwell
2019-02-04  4:36 ` David Miller
2019-01-29  5:17 Stephen Rothwell
2019-01-29  6:43 ` David Miller
2018-12-20  2:28 Stephen Rothwell
2018-12-20 10:43 ` Petr Machata
2018-12-17  1:36 Stephen Rothwell
2018-12-17 15:54 ` Paolo Abeni
2018-10-19  0:18 Stephen Rothwell
2018-10-19  5:48 ` Or Gerlitz
2018-09-02 23:47 Stephen Rothwell
2018-09-07  0:20 ` Stephen Rothwell
2018-09-07 15:30   ` Keller, Jacob E
2018-09-07 17:31     ` David Miller
2018-09-07 22:03       ` Keller, Jacob E
2018-08-06  2:10 Stephen Rothwell
2018-08-06  4:43 ` Y.b. Lu
2018-08-03  2:14 Stephen Rothwell
2018-08-03  2:34 ` Jakub Kicinski
2018-08-03  2:44 ` David Miller
2018-07-27 10:32 Stephen Rothwell
2018-07-27 12:18 ` YueHaibing
2018-07-03  0:47 Stephen Rothwell
2018-07-03  7:34 ` Sabrina Dubroca
2018-05-29  3:42 Stephen Rothwell
2018-05-29  5:41 ` Christoph Hellwig
2018-05-29  3:25 Stephen Rothwell
2018-05-30 21:38 ` Stephen Rothwell
2018-06-01  3:59   ` Stephen Rothwell
2018-06-01  8:52     ` Alexei Starovoitov
2018-06-06  4:49       ` Stephen Rothwell
2018-02-28 23:30 Stephen Rothwell
2018-01-29  1:50 Stephen Rothwell
2018-01-29  2:09 ` David Miller
2018-01-11  0:53 Stephen Rothwell
2018-01-11  1:58 ` Alexei Starovoitov
2018-01-12  3:11   ` David Miller
2018-01-12  4:21     ` Alexei Starovoitov
2018-01-12 10:45       ` Daniel Borkmann
2018-01-12 15:56         ` Alexei Starovoitov
2018-01-12 16:21           ` Daniel Borkmann
2018-01-12 16:43             ` Alexei Starovoitov
2018-01-10  4:06 Stephen Rothwell
2018-01-10  5:53 ` Jason Wang
2018-01-10 20:53 ` David Miller
2017-12-22  0:45 Stephen Rothwell
2017-12-22  7:51 ` Ido Schimmel
2017-12-20 23:43 Stephen Rothwell
2017-12-20 23:59 ` Jakub Kicinski
2017-09-29  1:36 Stephen Rothwell
2017-09-29  2:07 ` Florian Fainelli
2017-09-22  1:03 Stephen Rothwell
2017-09-22  1:37 ` David Miller
2017-09-22  7:10   ` Paolo Abeni
2017-08-15  2:28 Stephen Rothwell
2017-07-18  1:09 Stephen Rothwell
2017-07-18  4:59 ` John Fastabend
2017-05-22  1:16 Stephen Rothwell
2017-05-22  3:14 ` David Miller
2017-05-22  3:43   ` Stephen Rothwell
2017-05-22 14:17     ` David Miller
2017-05-22  3:42 ` Willem de Bruijn
2017-01-09 23:59 Stephen Rothwell
2017-01-10 15:14 ` Ursula Braun
2017-02-22 23:34 ` Stephen Rothwell
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:32 ` David Miller
2016-05-10  1:29 Stephen Rothwell
2016-05-10  1:52 ` Andy Gross
2016-05-10 18:39 ` Bjorn Andersson
2016-05-13 21:01   ` Arnd Bergmann
2016-04-13  7:50 Stephen Rothwell
2016-04-13 15:15 ` David Miller
2016-04-17  9:47   ` Arnd Bergmann
2016-04-22  9:20   ` Mark Brown
2016-04-22 23:20     ` Jeff Kirsher
2016-04-24 22:59       ` Mark Brown
2016-02-18  1:28 Stephen Rothwell
2016-02-18 20:28 ` David Miller
2016-02-18 22:14   ` Yuval Mintz
2016-01-11  2:46 Stephen Rothwell
2016-01-11  3:02 ` David Miller
2015-10-06  5:34 Stephen Rothwell
2015-08-24  3:21 Stephen Rothwell
2015-08-24  3:33 ` David Miller
2015-08-24  4:20   ` Stephen Rothwell
2015-08-20  2:57 Stephen Rothwell
2015-08-20  5:16 ` David Miller
2015-08-18  8:39 Stephen Rothwell
2015-08-18 21:25 ` David Miller
2015-07-23  1:58 Stephen Rothwell
2015-06-24  7:37 Stephen Rothwell
2015-06-24  8:01 ` David Miller
2015-06-01  3:44 Stephen Rothwell
2015-06-01  4:35 ` David Miller
2015-03-30  4:05 Stephen Rothwell
2015-03-31 18:13 ` David Miller
2015-03-24  2:45 Stephen Rothwell
2015-03-24  3:00 ` David Miller
2015-03-24 10:43   ` Christoph Hellwig
2015-03-24 15:59     ` David Miller
2015-03-05  2:42 Stephen Rothwell
2015-03-05  5:01 ` David Miller
2015-03-05 23:26   ` Stephen Rothwell
2015-03-06  2:01     ` David Miller
2015-03-06  2:42       ` Stephen Rothwell
2015-02-10 11:02 Stephen Rothwell
2015-02-11  4:51 ` Jeff Kirsher
2015-02-09  3:07 Stephen Rothwell
2015-02-09  5:52 ` David Miller
2015-01-19  3:06 Stephen Rothwell
2015-01-19  3:13 ` Marcel Holtmann
2015-01-19  3:30   ` Stephen Rothwell
2015-01-12  3:05 Stephen Rothwell
2015-01-12  3:08 ` David Miller
2015-01-12  3:12   ` Stephen Rothwell
2015-01-02 22:11 Stephen Rothwell
2015-01-02 22:21 ` Sedat Dilek
2015-01-02 23:32   ` Stephen Rothwell
2015-01-03  3:01 ` Stephen Rothwell
2015-01-03 19:45 ` David Miller
2015-01-05  3:36   ` Stephen Rothwell
2014-12-10  8:54 Stephen Rothwell
2014-12-10 10:14 ` Hariprasad S
2014-12-10 20:52 ` David Miller
2014-11-17  2:34 Stephen Rothwell
2014-11-22  3:30 ` David Miller
2014-10-01  7:04 Stephen Rothwell
2014-10-01  7:29 ` Jeff Kirsher
2014-10-01 17:42 ` David Miller
2014-09-30  3:13 Stephen Rothwell
2014-09-30  3:22 ` Stephen Rothwell
2014-07-18  4:35 Anish Bhatt
2014-07-18  3:21 Stephen Rothwell
2014-07-09  3:26 Stephen Rothwell
2014-07-09  3:47 ` David Miller
2014-07-09  3:53   ` Stephen Rothwell
2014-06-30  2:47 Stephen Rothwell
2014-06-30  6:47 ` David Miller
2014-06-12  2:14 Stephen Rothwell
2014-06-06  6:45 Stephen Rothwell
2014-06-06 13:21 ` Tom Lendacky
2014-06-06  4:06 Stephen Rothwell
2014-06-06  4:12 ` Alexei Starovoitov
2014-06-02  8:36 Stephen Rothwell
2014-05-19  3:38 Stephen Rothwell
2014-01-06  4:54 Stephen Rothwell
2014-01-06  5:10 ` Hannes Frederic Sowa
2013-12-19  0:57 Stephen Rothwell
2013-12-19 19:09 ` David Miller
2013-12-18  1:56 Stephen Rothwell
2013-12-18  2:21 ` David Miller
2013-12-18  2:30   ` David Miller
2013-12-18  8:33     ` Geert Uytterhoeven
2013-12-18 10:15       ` Peter Zijlstra
2013-12-18 10:32         ` Geert Uytterhoeven
2013-12-18 11:07           ` David Laight
2013-12-18 11:33             ` Peter Zijlstra
2013-12-18 11:36               ` Peter Zijlstra
2013-12-18 17:06         ` David Miller
2013-12-18 15:10     ` Francesco Fusco
2013-07-30  2:16 Stephen Rothwell
     [not found] ` <CAFkjPTny4TUFu9xrF-90DrJwXsfzBOpb_yYOwe_0r9ohsc2vcQ@mail.gmail.com>
2013-07-30 22:54   ` David Miller
2013-04-26  3:48 Stephen Rothwell
2013-04-30  8:03 ` David Miller
2013-04-22  3:27 Stephen Rothwell
2013-04-19  3:21 Stephen Rothwell
     [not found] ` <20130419132127.05ea53adec329ca794d62be7-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2013-04-19  7:34   ` Antonio Quartulli
2013-04-19  8:13     ` Stephen Rothwell
2013-04-23  0:39 ` David Miller
2013-02-19  1:17 Stephen Rothwell
2013-02-19  1:30 ` David Miller
2013-01-11  2:18 Stephen Rothwell
2012-09-28  1:43 Stephen Rothwell
2012-09-28  2:19 ` David Miller
2012-10-01 11:53   ` Ivan Vecera
2012-07-20  2:01 Stephen Rothwell
2012-07-20  2:48 ` Stephen Rothwell
2012-07-20  3:21 ` Christian Riesch
2012-07-10  3:08 Stephen Rothwell
2012-07-10  7:25 ` Bjørn Mork
2012-07-11  6:36 ` David Miller
2012-06-20  3:33 Stephen Rothwell
2012-06-20  4:24 ` David Miller
2012-06-20  4:27 ` Bhupesh SHARMA
2012-06-20  4:37   ` David Miller
2012-06-20  4:45     ` Bhupesh SHARMA
2012-06-20  4:47       ` David Miller
2012-06-20 11:35         ` Mark Brown
2012-06-20  8:31       ` Marc Kleine-Budde
2012-06-20  8:41         ` David Miller
2012-06-20  9:03         ` Federico Vaga
2012-06-20  9:06           ` David Miller
2012-06-20  9:59             ` Federico Vaga
2012-06-20  9:58               ` David Miller
2012-06-20 10:17                 ` Federico Vaga
2012-06-20  8:08   ` viresh kumar
2012-06-20  8:20     ` David Miller
2012-06-20  8:45       ` viresh kumar
2012-06-20 10:26       ` Stephen Rothwell
2012-06-20 10:33         ` Marc Kleine-Budde
     [not found] <20120423121451.c88c9bfaaf4d79313f7219f3@canb.auug.org.au>
2012-04-23  4:25 ` David Miller
2011-10-25 13:55 Stephen Rothwell
2011-10-25 14:16 ` Eric Dumazet

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-24035d0e-a382-4a48-89eb-eb00213fca7e@palmer-si-x1e \
    --to=palmer@sifive.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=yash.shah@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git