From: Palmer Dabbelt <palmer@rivosinc.com>
To: ndesaulniers@google.com
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Walmsley <paul@pwsan.com>,
alexghiti@rivosinc.com, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: linux-next: manual merge of the risc-v tree with Linus' tree
Date: Fri, 01 Sep 2023 08:46:02 -0700 (PDT) [thread overview]
Message-ID: <mhng-9e6725d0-707e-4350-a201-301f5aeaeb07@palmer-ri-x1c9> (raw)
In-Reply-To: <CAKwvOd=buFcfe3Ho7EfdTPQwDF06K90onCHaeCtd=w0Y2NQm7w@mail.gmail.com>
On Thu, 31 Aug 2023 10:50:15 PDT (-0700), ndesaulniers@google.com wrote:
> On Wed, Aug 30, 2023 at 4:29 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> Today's linux-next merge of the risc-v tree got a conflict in:
>>
>> arch/riscv/mm/kasan_init.c
>>
>> between commit:
>>
>> d2402048bc8a ("riscv: mm: fix 2 instances of -Wmissing-variable-declarations")
>>
>> from Linus' tree and commit:
>>
>> 56e1803d9de0 ("riscv: Mark KASAN tmp* page tables variables as static")
>>
>> from the risc-v tree.
>>
>> I fixed it up (see below) and can carry the fix as necessary. This
>> is now fixed as far as linux-next is concerned, but any non trivial
>> conflicts should be mentioned to your upstream maintainer when your tree
>> is submitted for merging. You may also want to consider cooperating
>> with the maintainer of the conflicting tree to minimise any particularly
>> complex conflicts.
>
> Fix LGTM; I guess Palmer you may need to rebase that branch on mainline?
Looks like I just missed it and Linus fixed it up, sorry about that --
for some reason my email hadn't been landing locally, I just fixed that
too ;)
>
>>
>> --
>> Cheers,
>> Stephen Rothwell
>>
>> diff --cc arch/riscv/mm/kasan_init.c
>> index a01bc15dce24,435e94a5b1bb..000000000000
>> --- a/arch/riscv/mm/kasan_init.c
>> +++ b/arch/riscv/mm/kasan_init.c
>> @@@ -22,9 -22,10 +22,9 @@@
>> * region is not and then we have to go down to the PUD level.
>> */
>>
>> - pgd_t tmp_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
>> - p4d_t tmp_p4d[PTRS_PER_P4D] __page_aligned_bss;
>> - pud_t tmp_pud[PTRS_PER_PUD] __page_aligned_bss;
>> -extern pgd_t early_pg_dir[PTRS_PER_PGD];
>> + static pgd_t tmp_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
>> + static p4d_t tmp_p4d[PTRS_PER_P4D] __page_aligned_bss;
>> + static pud_t tmp_pud[PTRS_PER_PUD] __page_aligned_bss;
>>
>> static void __init kasan_populate_pte(pmd_t *pmd, unsigned long vaddr, unsigned long end)
>> {
>
>
>
> --
> Thanks,
> ~Nick Desaulniers
next prev parent reply other threads:[~2023-09-01 15:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 23:29 linux-next: manual merge of the risc-v tree with Linus' tree Stephen Rothwell
2023-08-31 17:50 ` Nick Desaulniers
2023-09-01 15:46 ` Palmer Dabbelt [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-11 22:55 Stephen Rothwell
2024-01-07 22:49 Stephen Rothwell
2024-01-11 17:20 ` Palmer Dabbelt
2023-11-02 22:14 Stephen Rothwell
2023-08-30 23:25 Stephen Rothwell
2023-07-04 23:46 Stephen Rothwell
2023-06-04 22:51 Stephen Rothwell
2023-02-05 22:48 Stephen Rothwell
2023-02-05 22:40 Stephen Rothwell
2023-02-05 22:43 ` Stephen Rothwell
2023-01-08 21:42 Stephen Rothwell
2022-12-12 23:03 Stephen Rothwell
2022-10-13 22:11 Stephen Rothwell
2022-07-24 23:33 Stephen Rothwell
2022-03-22 22:06 Stephen Rothwell
2021-12-19 22:47 Stephen Rothwell
2021-07-05 23:32 Stephen Rothwell
2021-06-14 23:26 Stephen Rothwell
2021-04-26 23:42 Stephen Rothwell
2021-03-30 22:40 Stephen Rothwell
2021-04-02 4:33 ` Palmer Dabbelt
2021-02-23 22:00 Stephen Rothwell
2020-10-25 22:01 Stephen Rothwell
2020-01-13 22:05 Stephen Rothwell
2020-01-05 22:32 Stephen Rothwell
2020-01-06 1:50 ` Paul Walmsley
2020-01-06 1:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-9e6725d0-707e-4350-a201-301f5aeaeb07@palmer-ri-x1c9 \
--to=palmer@rivosinc.com \
--cc=alexghiti@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=paul@pwsan.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).