linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	gregkh@suse.de
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] usb: fix functionfs for CONFIG_NET disabled
Date: Thu, 13 May 2010 20:12:44 +0200	[thread overview]
Message-ID: <op.vcnovimh7p4s8u@pikus> (raw)
In-Reply-To: <20100513094112.86acf7c2.randy.dunlap@oracle.com>

On Thu, 13 May 2010 18:41:12 +0200, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Fix functionfs build to handle CONFIG_NET not enabled, to prevent
> these build errors:
>
> ERROR: "netif_carrier_on" [drivers/usb/gadget/g_ffs.ko] undefined!
[...]

> @@ -726,7 +726,7 @@ config USB_FUNCTIONFS
> config USB_FUNCTIONFS_ETH
>  	bool "Include CDC ECM (Ethernet) function"
> -	depends on USB_FUNCTIONFS
> +	depends on USB_FUNCTIONFS && NET
>  	help
>  	  Include an CDC ECM (Ethernet) funcion in the CDC ECM (Funcion)
>  	  Filesystem.  If you also say "y" to the RNDIS query below the
> @@ -734,7 +734,7 @@ config USB_FUNCTIONFS_ETH
> config USB_FUNCTIONFS_RNDIS
>  	bool "Include RNDIS (Ethernet) function"
> -	depends on USB_FUNCTIONFS
> +	depends on USB_FUNCTIONFS && NET
>  	help
>  	  Include an RNDIS (Ethernet) funcion in the Funcion Filesystem.
>  	  If you also say "y" to the CDC ECM query above the gadget will

Looks reasonable.  Thanks!

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--

      reply	other threads:[~2010-05-13 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13  7:15 linux-next: Tree for May 13 Stephen Rothwell
2010-05-13 16:41 ` [PATCH -next] usb: fix functionfs for CONFIG_NET disabled Randy Dunlap
2010-05-13 18:12   ` Michał Nazarewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.vcnovimh7p4s8u@pikus \
    --to=m.nazarewicz@samsung.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).