linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of Linus' tree
Date: Mon, 29 Jul 2019 08:58:00 +0200	[thread overview]
Message-ID: <s5h8sshpbt3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190729140404.37bac29e@canb.auug.org.au>

On Mon, 29 Jul 2019 06:04:04 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the origin tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get':
> sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity;
>                                      ^~~~~~~~~~~~
> 
> Introduced by commit
> 
>   f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> 
> This warning has been around for a long time.  It could possibly be
> suppressed by checking for errors returned by onyx_read_register().

Yes, or simply zero-ing the variable in onyx_read_register().  The
current code ignores the read error and it's been OK over a decade :)


thanks,

Takashi

  reply	other threads:[~2019-07-29  6:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  4:04 linux-next: build warning after merge of Linus' tree Stephen Rothwell
2019-07-29  6:58 ` Takashi Iwai [this message]
2019-07-29  7:03   ` Johannes Berg
2019-07-29  7:07     ` Takashi Iwai
2019-07-29  8:20       ` Stephen Rothwell
2021-10-01  7:18 Stephen Rothwell
2021-10-01 16:33 ` Eric Dumazet
2021-10-05  9:18 Stephen Rothwell
2021-10-05 10:10 ` Jeff Layton
2021-11-23  5:29 Stephen Rothwell
2022-01-20  3:27 ` Stephen Rothwell
2023-05-08  4:44 Stephen Rothwell
2023-05-08  6:28 ` Sakari Ailus
2024-03-13  4:04 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8sshpbt3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).