From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: linux-next: sound tree build failure Date: Fri, 17 Jul 2009 11:27:58 +0200 Message-ID: References: <20090717112935.2e831eee.sfr@canb.auug.org.au> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43092 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934279AbZGQJ17 (ORCPT ); Fri, 17 Jul 2009 05:27:59 -0400 In-Reply-To: <20090717112935.2e831eee.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>, Mark Brown , Greg KH At Fri, 17 Jul 2009 11:29:35 +1000, Stephen Rothwell wrote: > > [1 ] > Hi Takashi, > > Today's linux-next build (x86_64 allmodconfig) failed like this: > > sound/soc/codecs/ad1938.c: In function 'ad1938_spi_probe': > sound/soc/codecs/ad1938.c:423: error: 'struct device' has no member named 'driver_data' > sound/soc/codecs/ad1938.c: In function 'ad1938_spi_remove': > sound/soc/codecs/ad1938.c:430: error: 'struct device' has no member named 'driver_data' > > Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new > ad1938 codec driver based on asoc") interacting with commit > 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move > dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current > tree (which will, I assume, be sent to Linus shortly - right, Greg?). > > New drivers need to use the (existing) API's dev_{set,get}_drvdata(). Yep. Fixed now. > I have used the version of the sound tree from next-20090716 for today. thanks, Takashi