Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the sound tree
@ 2019-08-09  2:54 Stephen Rothwell
  2019-08-09  5:55 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2019-08-09  2:54 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
  v = readl(aligned_addr);
      ^~~~~
      d_real
sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
  writel(v, aligned_addr);
  ^~~~~~

Caused by commit

  19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 9 Aug 2019 12:50:25 +1000
Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h

Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/hda/hdac_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
index dc2523ef7d98..cd25e2b3f7f2 100644
--- a/sound/hda/hdac_bus.c
+++ b/sound/hda/hdac_bus.c
@@ -4,6 +4,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/io.h>
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/export.h>
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2019-08-09  2:54 linux-next: build failure after merge of the sound tree Stephen Rothwell
@ 2019-08-09  5:55 ` Takashi Iwai
  0 siblings, 0 replies; 18+ messages in thread
From: Takashi Iwai @ 2019-08-09  5:55 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List

On Fri, 09 Aug 2019 04:54:58 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
> sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
>   v = readl(aligned_addr);
>       ^~~~~
>       d_real
> sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
> sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
>   writel(v, aligned_addr);
>   ^~~~~~
> 
> Caused by commit
> 
>   19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
> 
> I have applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 9 Aug 2019 12:50:25 +1000
> Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h
> 
> Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  sound/hda/hdac_bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
> index dc2523ef7d98..cd25e2b3f7f2 100644
> --- a/sound/hda/hdac_bus.c
> +++ b/sound/hda/hdac_bus.c
> @@ -4,6 +4,7 @@
>   */
>  
>  #include <linux/init.h>
> +#include <linux/io.h>
>  #include <linux/device.h>
>  #include <linux/module.h>
>  #include <linux/export.h>

Thanks, it's obviously a right fix.

I applied it on top of topic/hda-bus-ops-cleanup branch branch.
Mark, feel free to pull it into yours again.


Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2017-05-17  1:29 Stephen Rothwell
@ 2017-05-17  5:30 ` Takashi Iwai
  0 siblings, 0 replies; 18+ messages in thread
From: Takashi Iwai @ 2017-05-17  5:30 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

On Wed, 17 May 2017 03:29:21 +0200,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from include/linux/delay.h:21:0,
>                  from sound/pcmcia/vx/vxp_ops.c:23:
> sound/pcmcia/vx/vxp_ops.c: In function 'vxp_dma_read':
> sound/pcmcia/vx/vxp_ops.c:406:43: error: '_chip' undeclared (first use in this function)
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                            ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                  ^
> sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                ^
> sound/pcmcia/vx/vxp_ops.c:406:43: note: each undeclared identifier is reported only once for each function it appears in
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                            ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                  ^
> sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                ^
> sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_boost':
> sound/pcmcia/vx/vxp_ops.c:470:43: error: '_chip' undeclared (first use in this function)
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                            ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                  ^
> sound/pcmcia/vx/vxp_ops.c:470:31: note: in expansion of macro 'to_vxpocket'
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                ^
> sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_level':
> sound/pcmcia/vx/vxp_ops.c:512:43: error: '_chip' undeclared (first use in this function)
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                            ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
>   const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>                                                  ^
> sound/pcmcia/vx/vxp_ops.c:512:31: note: in expansion of macro 'to_vxpocket'
>   struct snd_vxpocket *pchip = to_vxpocket(_chip);
>                                ^
> 
> Caused by commit
> 
>   7c46696e8fef ("ALSA: vxpocket: Use container_of()")
> 
> I have used the sound tree from next-20170516 for today.

My bad, I applied the wrong version of the patch.
Now fixed and pushed out.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2017-05-17  1:29 Stephen Rothwell
  2017-05-17  5:30 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2017-05-17  1:29 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/delay.h:21:0,
                 from sound/pcmcia/vx/vxp_ops.c:23:
sound/pcmcia/vx/vxp_ops.c: In function 'vxp_dma_read':
sound/pcmcia/vx/vxp_ops.c:406:43: error: '_chip' undeclared (first use in this function)
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                                           ^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                 ^
sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                               ^
sound/pcmcia/vx/vxp_ops.c:406:43: note: each undeclared identifier is reported only once for each function it appears in
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                                           ^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                 ^
sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                               ^
sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_boost':
sound/pcmcia/vx/vxp_ops.c:470:43: error: '_chip' undeclared (first use in this function)
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                                           ^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                 ^
sound/pcmcia/vx/vxp_ops.c:470:31: note: in expansion of macro 'to_vxpocket'
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                               ^
sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_level':
sound/pcmcia/vx/vxp_ops.c:512:43: error: '_chip' undeclared (first use in this function)
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                                           ^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \
                                                 ^
sound/pcmcia/vx/vxp_ops.c:512:31: note: in expansion of macro 'to_vxpocket'
  struct snd_vxpocket *pchip = to_vxpocket(_chip);
                               ^

Caused by commit

  7c46696e8fef ("ALSA: vxpocket: Use container_of()")

I have used the sound tree from next-20170516 for today.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2011-09-23  2:49 Stephen Rothwell
@ 2011-09-23  5:21 ` Takashi Iwai
  0 siblings, 0 replies; 18+ messages in thread
From: Takashi Iwai @ 2011-09-23  5:21 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

At Fri, 23 Sep 2011 12:49:34 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build ()
> failed like this:
> 
> sound/pci/fm801.c: In function 'snd_fm801_tea575x_get_pins':
> sound/pci/fm801.c:759:2: error: expected ',' or ';' before 'return'
> sound/pci/fm801.c:757:32: warning: unused variable 'gpio'
> sound/pci/fm801.c:756:17: warning: unused variable 'reg'
> sound/pci/fm801.c:761:1: warning: no return statement in function returning non-void
> sound/pci/fm801.c: In function 'snd_fm801_create':
> sound/pci/fm801.c:1251:5: error: implicit declaration of function 'get_tea57x_gpio'
> sound/pci/fm801.c:1251:5: error: invalid type argument of '->' (have 'int')
> 
> Caused by commit c51a94adef4c ("ALSA: fm801 - Clean up redundant reference to snd_fm801_tea575x_gpios[]").
> 
> I have used the sound tree from next-20110922 for today.

My bad, fixed now.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2011-09-23  2:49 Stephen Rothwell
  2011-09-23  5:21 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2011-09-23  2:49 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build ()
failed like this:

sound/pci/fm801.c: In function 'snd_fm801_tea575x_get_pins':
sound/pci/fm801.c:759:2: error: expected ',' or ';' before 'return'
sound/pci/fm801.c:757:32: warning: unused variable 'gpio'
sound/pci/fm801.c:756:17: warning: unused variable 'reg'
sound/pci/fm801.c:761:1: warning: no return statement in function returning non-void
sound/pci/fm801.c: In function 'snd_fm801_create':
sound/pci/fm801.c:1251:5: error: implicit declaration of function 'get_tea57x_gpio'
sound/pci/fm801.c:1251:5: error: invalid type argument of '->' (have 'int')

Caused by commit c51a94adef4c ("ALSA: fm801 - Clean up redundant reference to snd_fm801_tea575x_gpios[]").

I have used the sound tree from next-20110922 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2011-05-19  1:15 Stephen Rothwell
  0 siblings, 0 replies; 18+ messages in thread
From: Stephen Rothwell @ 2011-05-19  1:15 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Ben Gardiner

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

sound/core/pcm_lib.c:333:40: error: macro "xrun_log" passed 3 arguments, but takes just 2
sound/core/pcm_lib.c: In function 'snd_pcm_update_hw_ptr0':
sound/core/pcm_lib.c:333: error: 'xrun_log' undeclared (first use in this function)

Caused by commit ec08b14483de ("ALSA: sound, core, pcm_lib: xrun_log: log
also in_interrupt").  This build has CONFIG_SND_PCM_XRUN_DEBUG unset.

Please, please, use grep or some search when making API changes.

I have used the sound tree from next-20110518 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-09-23  6:04 ` Takashi Iwai
@ 2010-09-23  8:39   ` Mark Brown
  0 siblings, 0 replies; 18+ messages in thread
From: Mark Brown @ 2010-09-23  8:39 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Stephen Rothwell, linux-next, linux-kernel, Liam Girdwood

On Thu, Sep 23, 2010 at 08:04:45AM +0200, Takashi Iwai wrote:

> Ah, this was a quick fix for 2.6.36, but it needs to be reverted again
> for 2.6.37.  for-next branch contains 2.6.37 patches, thus it got
> broken.  I fixed now.  Mark, could you pull topic/asoc branch on my tree?

Will do, thanks.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-09-23  2:44 Stephen Rothwell
@ 2010-09-23  6:04 ` Takashi Iwai
  2010-09-23  8:39   ` Mark Brown
  0 siblings, 1 reply; 18+ messages in thread
From: Takashi Iwai @ 2010-09-23  6:04 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Mark Brown, Liam Girdwood

At Thu, 23 Sep 2010 12:44:45 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/soc-cache.c: In function 'snd_soc_8_16_write':
> sound/soc/soc-cache.c:207: error: 'struct snd_soc_codec' has no member named 'reg_cache_size'
> 
> Caused by commit 0077ca0b5c986477e33451b797b6e7dc92a8bbc0 ("ASoC: Fix
> multi-componentism") which looks like it was fixing something that didn't
> need fixing (or maybe fixed it incorrectly)?  This commit is not in the
> sound-asoc tree (but the commit it purports to be fixing is in both the
> sound and sound-asoc trees) ...
> 

Ah, this was a quick fix for 2.6.36, but it needs to be reverted again
for 2.6.37.  for-next branch contains 2.6.37 patches, thus it got
broken.  I fixed now.  Mark, could you pull topic/asoc branch on my tree?

Sorry for inconvenience.


Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2010-09-23  2:44 Stephen Rothwell
  2010-09-23  6:04 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2010-09-23  2:44 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Mark Brown, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/soc-cache.c: In function 'snd_soc_8_16_write':
sound/soc/soc-cache.c:207: error: 'struct snd_soc_codec' has no member named 'reg_cache_size'

Caused by commit 0077ca0b5c986477e33451b797b6e7dc92a8bbc0 ("ASoC: Fix
multi-componentism") which looks like it was fixing something that didn't
need fixing (or maybe fixed it incorrectly)?  This commit is not in the
sound-asoc tree (but the commit it purports to be fixing is in both the
sound and sound-asoc trees) ...

I have used the version of the sound tree from next-20100921 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-06-24  6:11 ` Takashi Iwai
@ 2010-06-28 16:33   ` Daniel Mack
  0 siblings, 0 replies; 18+ messages in thread
From: Daniel Mack @ 2010-06-28 16:33 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, Jun 24, 2010 at 08:11:00AM +0200, Takashi Iwai wrote:
> At Thu, 24 Jun 2010 13:03:41 +1000,
> Stephen Rothwell wrote:
> > 
> > Hi Takashi,
> > 
> > After merging the sound tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > sound/usb/mixer.c: In function 'get_ctl_value_v1':
> > sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'
> > 
> > Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
> > usb-audio: simplify control interface access").  Grep is your friend ...
> > 
> > I have used the sound tree from next-20100623 for today.
> 
> Fixed now.  I've forgotten the build tests with debug options...

Oops, sorry and thanks for fixing this up!

Daniel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-06-24  3:03 Stephen Rothwell
@ 2010-06-24  6:11 ` Takashi Iwai
  2010-06-28 16:33   ` Daniel Mack
  0 siblings, 1 reply; 18+ messages in thread
From: Takashi Iwai @ 2010-06-24  6:11 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Daniel Mack

At Thu, 24 Jun 2010 13:03:41 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/usb/mixer.c: In function 'get_ctl_value_v1':
> sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'
> 
> Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
> usb-audio: simplify control interface access").  Grep is your friend ...
> 
> I have used the sound tree from next-20100623 for today.

Fixed now.  I've forgotten the build tests with debug options...


thanks,

Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2010-06-24  3:03 Stephen Rothwell
  2010-06-24  6:11 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2010-06-24  3:03 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Daniel Mack

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/usb/mixer.c: In function 'get_ctl_value_v1':
sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'

Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
usb-audio: simplify control interface access").  Grep is your friend ...

I have used the sound tree from next-20100623 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-06-01  2:30 Stephen Rothwell
@ 2010-06-01  5:47 ` Takashi Iwai
  0 siblings, 0 replies; 18+ messages in thread
From: Takashi Iwai @ 2010-06-01  5:47 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Daniel Mack

At Tue, 1 Jun 2010 12:30:11 +1000,
Stephen Rothwell wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/usb/gadget/audio.c:37:
> drivers/usb/gadget/f_audio.c:104: error: 'UAC_MUTE_CONTROL' undeclared here (not in a function)
> drivers/usb/gadget/f_audio.c:113: error: 'UAC_VOLUME_CONTROL' undeclared here (not in a function)
> 
> Presumably caused by commit 65f25da44b51f55e3a74301c25f29263be2bf1ba
> ("ALSA: usb-audio: unify constants from specification").
> 
> I have used the version of the sound tree from next-20100531 for today.

Oops, I forgot to run the build test of the whole tree...
Fixed it now like below.


thanks,

Takashi

---
>From f07ff97b012ff9485618faeadcc9b1e5f72ceefa Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 1 Jun 2010 07:42:03 +0200
Subject: [PATCH] usb/gadget: Replace the old USB audio FU definitions in f_audio.c

The USB audio FU definitions were renewed by the commit
    65f25da44b51f55e3a74301c25f29263be2bf1ba
    ALSA: usb-audio: unify constants from specification

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 drivers/usb/gadget/f_audio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/f_audio.c b/drivers/usb/gadget/f_audio.c
index 43bf445..b91115f 100644
--- a/drivers/usb/gadget/f_audio.c
+++ b/drivers/usb/gadget/f_audio.c
@@ -101,7 +101,7 @@ static struct uac_feature_unit_descriptor_0 feature_unit_desc = {
 static struct usb_audio_control mute_control = {
 	.list = LIST_HEAD_INIT(mute_control.list),
 	.name = "Mute Control",
-	.type = UAC_MUTE_CONTROL,
+	.type = UAC_FU_MUTE,
 	/* Todo: add real Mute control code */
 	.set = generic_set_cmd,
 	.get = generic_get_cmd,
@@ -110,7 +110,7 @@ static struct usb_audio_control mute_control = {
 static struct usb_audio_control volume_control = {
 	.list = LIST_HEAD_INIT(volume_control.list),
 	.name = "Volume Control",
-	.type = UAC_VOLUME_CONTROL,
+	.type = UAC_FU_VOLUME,
 	/* Todo: add real Volume control code */
 	.set = generic_set_cmd,
 	.get = generic_get_cmd,
-- 
1.7.0.3

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2010-06-01  2:30 Stephen Rothwell
  2010-06-01  5:47 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2010-06-01  2:30 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Daniel Mack

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/usb/gadget/audio.c:37:
drivers/usb/gadget/f_audio.c:104: error: 'UAC_MUTE_CONTROL' undeclared here (not in a function)
drivers/usb/gadget/f_audio.c:113: error: 'UAC_VOLUME_CONTROL' undeclared here (not in a function)

Presumably caused by commit 65f25da44b51f55e3a74301c25f29263be2bf1ba
("ALSA: usb-audio: unify constants from specification").

I have used the version of the sound tree from next-20100531 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-04-07  6:06 ` Takashi Iwai
@ 2010-04-07  7:16   ` Stephen Rothwell
  0 siblings, 0 replies; 18+ messages in thread
From: Stephen Rothwell @ 2010-04-07  7:16 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Risto Suominen

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Hi Takashi,

On Wed, 07 Apr 2010 08:06:13 +0200 Takashi Iwai <tiwai@suse.de> wrote:
>
> Fixed now.  Thanks.

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: linux-next: build failure after merge of the sound tree
  2010-04-07  3:39 Stephen Rothwell
@ 2010-04-07  6:06 ` Takashi Iwai
  2010-04-07  7:16   ` Stephen Rothwell
  0 siblings, 1 reply; 18+ messages in thread
From: Takashi Iwai @ 2010-04-07  6:06 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Risto Suominen

At Wed, 7 Apr 2010 13:39:19 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> sound/ppc/tumbler.c: In function 'tumbler_find_device':
> sound/ppc/tumbler.c:1143: error: implicit declaration of function 'machine_is_compatible'
> 
> Caused by commit 819ef70b135ba66cd1659c913255686bf931e3d4 ("ALSA:
> powermac - Reverse HP detection on G4 DA").  machine_is_compatible was
> renamed to of_machine_is_compatible by commit
> 71a157e8edca55198e808f8561dd49017a54ee34 ("of: add 'of_' prefix to
> machine_is_compatible()") in Linus' tree since Feb 26, 2010 (and is in
> v2.6.34-rc1).
> 
> I have used the version of the sound tree from next-20100401 for today.

Fixed now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 18+ messages in thread

* linux-next: build failure after merge of the sound tree
@ 2010-04-07  3:39 Stephen Rothwell
  2010-04-07  6:06 ` Takashi Iwai
  0 siblings, 1 reply; 18+ messages in thread
From: Stephen Rothwell @ 2010-04-07  3:39 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next, linux-kernel, Risto Suominen

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

sound/ppc/tumbler.c: In function 'tumbler_find_device':
sound/ppc/tumbler.c:1143: error: implicit declaration of function 'machine_is_compatible'

Caused by commit 819ef70b135ba66cd1659c913255686bf931e3d4 ("ALSA:
powermac - Reverse HP detection on G4 DA").  machine_is_compatible was
renamed to of_machine_is_compatible by commit
71a157e8edca55198e808f8561dd49017a54ee34 ("of: add 'of_' prefix to
machine_is_compatible()") in Linus' tree since Feb 26, 2010 (and is in
v2.6.34-rc1).

I have used the version of the sound tree from next-20100401 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, back to index

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  2:54 linux-next: build failure after merge of the sound tree Stephen Rothwell
2019-08-09  5:55 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2017-05-17  1:29 Stephen Rothwell
2017-05-17  5:30 ` Takashi Iwai
2011-09-23  2:49 Stephen Rothwell
2011-09-23  5:21 ` Takashi Iwai
2011-05-19  1:15 Stephen Rothwell
2010-09-23  2:44 Stephen Rothwell
2010-09-23  6:04 ` Takashi Iwai
2010-09-23  8:39   ` Mark Brown
2010-06-24  3:03 Stephen Rothwell
2010-06-24  6:11 ` Takashi Iwai
2010-06-28 16:33   ` Daniel Mack
2010-06-01  2:30 Stephen Rothwell
2010-06-01  5:47 ` Takashi Iwai
2010-04-07  3:39 Stephen Rothwell
2010-04-07  6:06 ` Takashi Iwai
2010-04-07  7:16   ` Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox