linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Gabriel C <nix.or.die@googlemail.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-next@vger.kernel.org, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] sound/pcmcia/vx build error
Date: Wed, 21 May 2008 20:53:05 +0200	[thread overview]
Message-ID: <s5hd4nfo5f2.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080521113721.a9de4700.randy.dunlap@oracle.com>

At Wed, 21 May 2008 11:37:21 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> menuconfig in Sound PCMCIA drivers needs to be tristate so that SND_PCMCIA
> can have a value of m so that following drivers can be restricted to m
> when needed.
> 
> sound/built-in.o: In function `vxpocket_detach':
> vxpocket.c:(.text+0x20cfa): undefined reference to `pcmcia_disable_device'
> sound/built-in.o: In function `vxpocket_probe':
> vxpocket.c:(.text+0x20f46): undefined reference to `pcmcia_request_io'
> vxpocket.c:(.text+0x20f5a): undefined reference to `pcmcia_request_irq'
> vxpocket.c:(.text+0x20f73): undefined reference to `pcmcia_request_configuration'
> vxpocket.c:(.text+0x2101f): undefined reference to `cs_error'
> vxpocket.c:(.text+0x21027): undefined reference to `pcmcia_disable_device'
> sound/built-in.o: In function `init_vxpocket':
> vxpocket.c:(.init.text+0x75b): undefined reference to `pcmcia_register_driver'
> sound/built-in.o: In function `exit_vxpocket':
> vxpocket.c:(.exit.text+0x28c): undefined reference to `pcmcia_unregister_driver'
> make: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, applied to my tree now.


Takashi

> ---
>  sound/pcmcia/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20080521.orig/sound/pcmcia/Kconfig
> +++ linux-next-20080521/sound/pcmcia/Kconfig
> @@ -1,7 +1,7 @@
>  # ALSA PCMCIA drivers
>  
>  menuconfig SND_PCMCIA
> -	bool "PCMCIA sound devices"
> +	tristate "PCMCIA sound devices"
>  	depends on PCMCIA
>  	default y
>  	help
> 

      reply	other threads:[~2008-05-21 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 17:47 linux-next: sound/pcmcia/vx build error Gabriel C
2008-05-21 18:37 ` [PATCH -next] " Randy Dunlap
2008-05-21 18:53   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd4nfo5f2.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=nix.or.die@googlemail.com \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).