From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm Date: Fri, 22 Nov 2013 10:25:03 +0100 Message-ID: References: <1385077794-17022-1-git-send-email-vincent.stehle@laposte.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from cantor2.suse.de ([195.135.220.15]:59900 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190Ab3KVJZF (ORCPT ); Fri, 22 Nov 2013 04:25:05 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Vincent =?UTF-8?B?U3RlaGzDqQ==?= , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-Next , Karsten Keil At Fri, 22 Nov 2013 10:19:07 +0100, Geert Uytterhoeven wrote: > > On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai wrote: > >> config HISAX_TELESPCI > >> bool "Teles PCI" > >> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > >> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) > > > > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally? > > > > depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM)) > > CPU_LITTLE_ENDIAN is not defined on all little endian platforms, > only on those that can support both big and little endian. Ah, a good point. > But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to > a common Kconfig file. Yeah, this make life easier. thanks, Takashi