From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] sound: fix lola build
Date: Wed, 04 May 2011 19:54:33 +0200 [thread overview]
Message-ID: <s5hpqnyjqqu.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110504095310.465fae53.randy.dunlap@oracle.com>
At Wed, 4 May 2011 09:53:10 -0700,
Randy Dunlap wrote:
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> sound/pci/lola/Makefile was trying to build lola modules even
> when PCI and SND_LOLA were not enabled, causing build errors:
>
> ERROR: "snd_pcm_hw_constraint_step" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_period_elapsed" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_dma_alloc_pages" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_hw_constraint_integer" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_sgbuf_ops_page" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_set_ops" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_lib_free_pages" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_lib_ioctl" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_lib_malloc_pages" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_sgbuf_get_chunk_size" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_dma_free_pages" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_lib_preallocate_pages_for_all" [sound/pci/lola/snd-lola.ko] undefined!
> ERROR: "snd_pcm_new" [sound/pci/lola/snd-lola.ko] undefined!
>
> Fix the Makefile to build only when CONFIG_SND_LOLA is enabled.
Gah, this was taken over from the devel branch and I forgot to fix
at the merge time. Thanks for noticing.
Takashi
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> sound/pci/lola/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20110504.orig/sound/pci/lola/Makefile
> +++ linux-next-20110504/sound/pci/lola/Makefile
> @@ -1,3 +1,4 @@
> snd-lola-y := lola.o lola_pcm.o lola_clock.o lola_mixer.o
> snd-lola-$(CONFIG_SND_DEBUG) += lola_proc.o
> -obj-m = snd-lola.o
> +
> +obj-$(CONFIG_SND_LOLA) += snd-lola.o
>
next prev parent reply other threads:[~2011-05-04 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 4:47 linux-next: Tree for May 4 Stephen Rothwell
2011-05-04 16:49 ` linux-next: Tree for May 4 (hyperv / vmbus) Randy Dunlap
2011-05-04 16:56 ` KY Srinivasan
2011-05-04 18:34 ` Greg KH
2011-05-05 14:59 ` Hank Janssen
2011-05-05 15:02 ` KY Srinivasan
2011-05-05 15:08 ` Hank Janssen
2011-05-04 16:53 ` [PATCH -next] sound: fix lola build Randy Dunlap
2011-05-04 17:54 ` Takashi Iwai [this message]
2011-05-04 16:56 ` [PATCH -next] x86/net: only select BPF_JIT when NET is enabled Randy Dunlap
2011-05-04 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpqnyjqqu.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).