Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the tip tree
@ 2018-08-08 23:24 Stephen Rothwell
  2018-08-09  9:41 ` Joerg Roedel
  2018-08-09  9:44 ` [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL Joerg Roedel
  0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2018-08-08 23:24 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Joerg Roedel

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi all,

After merging the tip tree, today's linux-next build (x86_64 defconfig)
failed like this:

Invalid absolute R_X86_64_32S relocation: __end_rodata_aligned
/kisskb/src/arch/x86/boot/compressed/Makefile:127: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed

Caused by commit

  39d668e04eda ("x86/mm/pti: Make pti_clone_kernel_text() compile on 32 bit")

This was a build using gcc 4.6.3.  the i386 defconfig also failed
like this:

Invalid absolute R_386_32 relocation: __end_rodata_aligned

They started failing on next-20180723 (which is the first -next that
contained the above commit).  Sorry that we did not notice this earlier.
At least the i386 defconfig build works with gcc 7.3.1.

You can see the full build results here:
http://kisskb.ellerman.id.au/kisskb/head/6b522b734da2950c368aae668f963b8925fb5545/

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the tip tree
  2018-08-08 23:24 linux-next: build failure after merge of the tip tree Stephen Rothwell
@ 2018-08-09  9:41 ` Joerg Roedel
  2018-08-09  9:44 ` [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL Joerg Roedel
  1 sibling, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2018-08-09  9:41 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

On Thu, Aug 09, 2018 at 09:24:20AM +1000, Stephen Rothwell wrote:
> Invalid absolute R_X86_64_32S relocation: __end_rodata_aligned
> /kisskb/src/arch/x86/boot/compressed/Makefile:127: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> 
> Caused by commit
> 
>   39d668e04eda ("x86/mm/pti: Make pti_clone_kernel_text() compile on 32 bit")

Thanks for the report! I only built the source with gcc-4.8 and gcc-7.3,
so I didn't catch this earlier. I have a fix now and will send it as a
separate reply in this thread.


Thanks,

	Joerg

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL
  2018-08-08 23:24 linux-next: build failure after merge of the tip tree Stephen Rothwell
  2018-08-09  9:41 ` Joerg Roedel
@ 2018-08-09  9:44 ` Joerg Roedel
  2018-08-09 12:18   ` Sedat Dilek
  2018-08-09 18:45   ` [tip:x86/pti] x86/relocs: " tip-bot for Joerg Roedel
  1 sibling, 2 replies; 5+ messages in thread
From: Joerg Roedel @ 2018-08-09  9:44 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Stephen Rothwell

This new symbol needs to be in the workaround-list for buggy
binutils, otherwise the build with gcc-4.6 fails.

Fixes: 39d668e04eda ('x86/mm/pti: Make pti_clone_kernel_text() compile on 32 bit')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 arch/x86/tools/relocs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index 220e97841e49..3a6c8ebc8032 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -67,6 +67,7 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
 	"__tracedata_(start|end)|"
 	"__(start|stop)_notes|"
 	"__end_rodata|"
+	"__end_rodata_aligned|"
 	"__initramfs_start|"
 	"(jiffies|jiffies_64)|"
 #if ELF_BITS == 64
-- 
2.16.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL
  2018-08-09  9:44 ` [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL Joerg Roedel
@ 2018-08-09 12:18   ` Sedat Dilek
  2018-08-09 18:45   ` [tip:x86/pti] x86/relocs: " tip-bot for Joerg Roedel
  1 sibling, 0 replies; 5+ messages in thread
From: Sedat Dilek @ 2018-08-09 12:18 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	Linux-Next Mailing List, Linux Kernel Mailing List,
	Stephen Rothwell

On Thu, Aug 9, 2018 at 11:44 AM, Joerg Roedel <jroedel@suse.de> wrote:
> This new symbol needs to be in the workaround-list for buggy
> binutils, otherwise the build with gcc-4.6 fails.
>
> Fixes: 39d668e04eda ('x86/mm/pti: Make pti_clone_kernel_text() compile on 32 bit')
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
>  arch/x86/tools/relocs.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
> index 220e97841e49..3a6c8ebc8032 100644
> --- a/arch/x86/tools/relocs.c
> +++ b/arch/x86/tools/relocs.c
> @@ -67,6 +67,7 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
>         "__tracedata_(start|end)|"
>         "__(start|stop)_notes|"
>         "__end_rodata|"
> +       "__end_rodata_aligned|"
>         "__initramfs_start|"
>         "(jiffies|jiffies_64)|"
>  #if ELF_BITS == 64
> --
> 2.16.4
>

Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip:x86/pti] x86/relocs: Add __end_rodata_aligned to S_REL
  2018-08-09  9:44 ` [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL Joerg Roedel
  2018-08-09 12:18   ` Sedat Dilek
@ 2018-08-09 18:45   ` " tip-bot for Joerg Roedel
  1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Joerg Roedel @ 2018-08-09 18:45 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: tglx, sfr, linux-next, sedat.dilek, hpa, jroedel, peterz, mingo,
	linux-kernel

Commit-ID:  a29dba161ad1a01bbfbc80aa184b089ddd169a4e
Gitweb:     https://git.kernel.org/tip/a29dba161ad1a01bbfbc80aa184b089ddd169a4e
Author:     Joerg Roedel <jroedel@suse.de>
AuthorDate: Thu, 9 Aug 2018 11:44:49 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 9 Aug 2018 20:42:07 +0200

x86/relocs: Add __end_rodata_aligned to S_REL

This new symbol needs to be in the workaround-list for buggy
binutils, otherwise the build with gcc-4.6 fails.

Fixes: 39d668e04eda ('x86/mm/pti: Make pti_clone_kernel_text() compile on 32 bit')
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>
Link: https://lkml.kernel.org/r/20180809094449.ddmnrkz7qkvo3j2x@suse.de

---
 arch/x86/tools/relocs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index 220e97841e49..3a6c8ebc8032 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -67,6 +67,7 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
 	"__tracedata_(start|end)|"
 	"__(start|stop)_notes|"
 	"__end_rodata|"
+	"__end_rodata_aligned|"
 	"__initramfs_start|"
 	"(jiffies|jiffies_64)|"
 #if ELF_BITS == 64

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08 23:24 linux-next: build failure after merge of the tip tree Stephen Rothwell
2018-08-09  9:41 ` Joerg Roedel
2018-08-09  9:44 ` [PATCH] x86, relocs: Add __end_rodata_aligned to S_REL Joerg Roedel
2018-08-09 12:18   ` Sedat Dilek
2018-08-09 18:45   ` [tip:x86/pti] x86/relocs: " tip-bot for Joerg Roedel

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git