From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: [linux-nfc] [neard][PATCH v2 00/73] combined fixes - warnings, memory leaks, memory corruption
Date: Mon, 19 Jul 2021 13:07:06 +0200 [thread overview]
Message-ID: <20210719110819.27340-1-krzysztof.kozlowski@canonical.com> (raw)
Hi,
Mark asked for resending fixes separate from setting up CI under Github
Actions, so here is a combination of all my previously sent patches
related only to the actual C code:
https://lore.kernel.org/linux-nfc/20210710033859.3989-1-krzysztof.kozlowski@canonical.com/T/#t
https://lore.kernel.org/linux-nfc/20210711202102.18094-1-krzysztof.kozlowski@canonical.com/T/#t
https://lore.kernel.org/linux-nfc/20210714110518.104655-1-krzysztof.kozlowski@canonical.com/T/#t
https://lore.kernel.org/linux-nfc/20210716100844.51360-1-krzysztof.kozlowski@canonical.com/T/#t
This includes fixes for GCC/clang warnings, memory leaks, memory
corruption and few other minor fixes. The UTF-8 and UTF-16 is not
entirely fixed and I removed the work-in-progress patches.
Changes since v1 are:
1. Group all patches based on prefix (unit file), instead of topic.
2. Put the build-related patches at the end.
3. Remove all CI-related patches.
4. Drop patch: ndef: fix parsing of UTF-16 text payload.
5. Fix commit msg in: nfctool: pass the format as string literal
Best regards,
Krzysztof
Krzysztof Kozlowski (73):
Drop empty NEWS
nfctool: fix adapter_get_devices() cast-function-type
nfctool: fix adapter_print_target() cast-function-type
nfctool: fix adapter_print_info() cast-function-type
nfctool: fix adapter_compare_idx() cast-function-type
nfctool: fix nfctool_send_dep_link_up() cast-function-type
nfctool: fix nfctool_print_and_remove_snl() cast-function-type
nfctool: use proper format for integers (-Wformat)
nfctool: pass the format as string literal
dbus: fix -Wformat in near_dbus_encode_string()
unit: pass real UTF-8 for testing text NDEF
ndef: check UTF-16 text payload length
ndef: silence clang -Wcast-align warning
ndef: use NDEF_TEXT_RECORD_UTF16_STATUS define
ndef: use proper format for integers (-Wformat)
ndef: make freeing near_ndef_message reusable
se: fix multiple apdu definitions
se: silence clang -Wcast-align warning
se: use proper format for integers (-Wformat)
adapter: adjust indentation of continued arguments
adapter: use proper format for integers (-Wformat)
gdbus: do not shadow global 'pending' variable (-Wshadow)
nciattach: fix poll.h include location
nciattach: do not shadow other local 'opt' variable (-Wshadow)
bluetooth: use proper format for integers (-Wformat)
nfctype2: use proper format for integers (-Wformat)
nfctype3: use proper format for integers (-Wformat)
nfctype5: use proper format for integers (-Wformat)
nfctype5: fix returning uninitialized stack value in
t5_tag_is_ti_pro()
mifare: use proper format for integers (-Wformat)
mifare: use unsigned int to suppress compiler -Wstrict-overflow
p2p: use proper format for integers (-Wformat)
npp: use proper format for integers (-Wformat)
device: use proper format for integers (-Wformat)
manager: use proper format for integers (-Wformat)
netlink: use proper format for integers (-Wformat)
gdbus: annotate printf-like functions as accepting format
snep-send: fix near_ndef_message memory leak
tag: use proper format for integers (-Wformat)
tag: do not open-code freeing ndef message
snep: do not open-code freeing ndef message
snep: remove useless NULL-ify of local pointer variable
snep: fix double free of GSList
snep: fix fragmented response memory leaks
unit: use g_assert_cmpstr()
unit: use g_assert_cmpint() and g_assert_cmpuint()
unit: fix recv() and send() return types
unit: use g_assert_null()
unit: use g_assert_cmpmem()
unit: use proper pointer to uint8_t in test_snep_read_recv_fragments()
unit: do not shadow global 'text' variable (-Wshadow)
unit: do not shadow global 'uri' variable (-Wshadow)
unit: use proper format for integers (-Wformat)
unit: fix memory leaks in test-ndef-parse
unit: do not open-code freeing ndef message
unit: fix memory leaks in test-ndef-build
unit: fix memory leaks in test-snep-read error paths
unit: fix record memory leak in test-snep-read
unit: fix records GList memory leak in test-snep-read
unit: do not pass NULL to memcpy()
unit: do not search for headers locally where they do not exist
unit: remove duplicated invalid definitions in test-snep-read
unit: remove duplicated definitions in test-ndef-parse
unit: add few asserts in test-snep-read
HACKING: refine required packages
build: fix setting CFLAGS on dash shell (Alpine Linux)
build: add more compiler warnings
build: enable -Wshadow and -Wformat-signedness compiler warnings
build: enable -Wformat=2 warnings
build: enable -Wunsafe-loop-optimizations and -Wstrict-overflow=2
warnings
build: fix missing usage of PIE check result
build: add support for GCC sanitizers (asan, lsan and ubsan)
AUTHORS: Mention Krzysztof Kozlowski's contributions
AUTHORS | 1 +
HACKING | 27 ++--
Makefile.am | 2 +-
NEWS | 0
accflags.m4 | 52 +++++++
acinclude.m4 | 44 ++++--
configure.ac | 52 ++++++-
gdbus/gdbus.h | 15 +-
gdbus/object.c | 22 +--
include/ndef.h | 1 +
plugins/mifare.c | 14 +-
plugins/nfctype2.c | 12 +-
plugins/nfctype3.c | 2 +-
plugins/nfctype5.c | 8 +-
plugins/npp.c | 2 +-
plugins/p2p.c | 4 +-
se/ace.c | 64 ++++++---
se/apdu.c | 8 +-
se/plugins/nfc.c | 8 +-
se/plugins/tizen.c | 2 +-
se/se.c | 6 +-
se/seel.h | 2 +-
src/adapter.c | 41 +++---
src/bluetooth.c | 4 +-
src/dbus.c | 2 +-
src/device.c | 6 +-
src/manager.c | 4 +-
src/ndef-private.h | 140 ++++++++++++++++++
src/ndef.c | 217 ++++++----------------------
src/netlink.c | 16 +--
src/snep.c | 14 +-
src/tag.c | 14 +-
tools/nciattach.c | 10 +-
tools/nfctool/adapter.c | 20 +--
tools/nfctool/adapter.h | 2 +-
tools/nfctool/llcp-decode.c | 4 +-
tools/nfctool/main.c | 30 ++--
tools/nfctool/sniffer.c | 10 +-
tools/snep-send.c | 2 +
unit/test-ndef-build.c | 24 ++--
unit/test-ndef-parse.c | 278 +++++++++++-------------------------
unit/test-snep-read.c | 117 ++++++++-------
unit/test-utils.c | 8 --
unit/test-utils.h | 83 +----------
44 files changed, 691 insertions(+), 703 deletions(-)
delete mode 100644 NEWS
create mode 100644 accflags.m4
create mode 100644 src/ndef-private.h
--
2.27.0
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
next reply other threads:[~2021-07-19 11:08 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 11:07 Krzysztof Kozlowski [this message]
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 01/73] Drop empty NEWS Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 02/73] nfctool: fix adapter_get_devices() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 03/73] nfctool: fix adapter_print_target() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 04/73] nfctool: fix adapter_print_info() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 05/73] nfctool: fix adapter_compare_idx() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 06/73] nfctool: fix nfctool_send_dep_link_up() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 07/73] nfctool: fix nfctool_print_and_remove_snl() cast-function-type Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 08/73] nfctool: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 09/73] nfctool: pass the format as string literal Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 10/73] dbus: fix -Wformat in near_dbus_encode_string() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 11/73] unit: pass real UTF-8 for testing text NDEF Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 12/73] ndef: check UTF-16 text payload length Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 13/73] ndef: silence clang -Wcast-align warning Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 14/73] ndef: use NDEF_TEXT_RECORD_UTF16_STATUS define Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 15/73] ndef: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 16/73] ndef: make freeing near_ndef_message reusable Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 17/73] se: fix multiple apdu definitions Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 18/73] se: silence clang -Wcast-align warning Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 19/73] se: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 20/73] adapter: adjust indentation of continued arguments Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 21/73] adapter: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 22/73] gdbus: do not shadow global 'pending' variable (-Wshadow) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 23/73] nciattach: fix poll.h include location Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 24/73] nciattach: do not shadow other local 'opt' variable (-Wshadow) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 25/73] bluetooth: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 26/73] nfctype2: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 27/73] nfctype3: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 28/73] nfctype5: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 29/73] nfctype5: fix returning uninitialized stack value in t5_tag_is_ti_pro() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 30/73] mifare: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 31/73] mifare: use unsigned int to suppress compiler -Wstrict-overflow Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 32/73] p2p: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 33/73] npp: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 34/73] device: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 35/73] manager: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 36/73] netlink: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 37/73] gdbus: annotate printf-like functions as accepting format Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 38/73] snep-send: fix near_ndef_message memory leak Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 39/73] tag: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 40/73] tag: do not open-code freeing ndef message Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 41/73] snep: " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 42/73] snep: remove useless NULL-ify of local pointer variable Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 43/73] snep: fix double free of GSList Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 44/73] snep: fix fragmented response memory leaks Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 45/73] unit: use g_assert_cmpstr() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 46/73] unit: use g_assert_cmpint() and g_assert_cmpuint() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 47/73] unit: fix recv() and send() return types Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 48/73] unit: use g_assert_null() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 49/73] unit: use g_assert_cmpmem() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 50/73] unit: use proper pointer to uint8_t in test_snep_read_recv_fragments() Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 51/73] unit: do not shadow global 'text' variable (-Wshadow) Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 52/73] unit: do not shadow global 'uri' " Krzysztof Kozlowski
2021-07-19 11:07 ` [linux-nfc] [neard][PATCH v2 53/73] unit: use proper format for integers (-Wformat) Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 54/73] unit: fix memory leaks in test-ndef-parse Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 55/73] unit: do not open-code freeing ndef message Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 56/73] unit: fix memory leaks in test-ndef-build Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 57/73] unit: fix memory leaks in test-snep-read error paths Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 58/73] unit: fix record memory leak in test-snep-read Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 59/73] unit: fix records GList " Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 60/73] unit: do not pass NULL to memcpy() Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 61/73] unit: do not search for headers locally where they do not exist Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 62/73] unit: remove duplicated invalid definitions in test-snep-read Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 63/73] unit: remove duplicated definitions in test-ndef-parse Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 64/73] unit: add few asserts in test-snep-read Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 65/73] HACKING: refine required packages Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 66/73] build: fix setting CFLAGS on dash shell (Alpine Linux) Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 67/73] build: add more compiler warnings Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 68/73] build: enable -Wshadow and -Wformat-signedness " Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 69/73] build: enable -Wformat=2 warnings Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 70/73] build: enable -Wunsafe-loop-optimizations and -Wstrict-overflow=2 warnings Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 71/73] build: fix missing usage of PIE check result Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 72/73] build: add support for GCC sanitizers (asan, lsan and ubsan) Krzysztof Kozlowski
2021-07-19 11:08 ` [linux-nfc] [neard][PATCH v2 73/73] AUTHORS: Mention Krzysztof Kozlowski's contributions Krzysztof Kozlowski
2021-07-19 11:21 ` [linux-nfc] Re: [neard][PATCH v2 00/73] combined fixes - warnings, memory leaks, memory corruption Krzysztof Kozlowski
2021-07-19 16:32 ` Mark Greer
2021-08-01 23:11 ` Mark Greer
2021-08-02 7:51 ` Krzysztof Kozlowski
2021-08-04 7:56 ` Krzysztof Kozlowski
2021-08-05 16:14 ` Mark Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719110819.27340-1-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).