From: Mark Greer <mgreer@animalcreek.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: "linux-nfc@lists.01.org" <linux-nfc@lists.01.org>
Subject: [linux-nfc] Re: [PATCH v2] tag: Implement readout of tag UID via DBus interface
Date: Sat, 7 Aug 2021 18:55:32 -0700 [thread overview]
Message-ID: <20210808015532.GE124928@animalcreek.com> (raw)
In-Reply-To: <e925f779-3be9-1d11-81ea-e8841f55381a@kontron.de>
On Thu, Mar 18, 2021 at 05:14:35PM +0100, Frieder Schrempf wrote:
> Hi Fabian,
>
> On 16.03.21 19:49, Gottstein, Fabian wrote:
> > Hi Frieder,
> >
> > thanks for the patch.
>
> thanks for your feedback.
>
> >
> > Could you please also consider the following situation:
> > In the case of a NFC Tag Type 1, the identifier is delivered via the RID command (see NFC Digital Protocol). Thus, the Tag's nfcid property is updated in a later step.
> > To inform the neard users, a property changed signal has to be emitted when nfcid has changed (in near_tag_set_nfcid). Also, a exists() handler for the new DBus property should be implemented.
>
> I'm new to NFC and D-Bus, so I don't know much about what use-cases and
> requirements there are.
>
> Your request sounds reasonable and I think I have a rough understanding of
> what is probably needed to implement this. Still to actually do this I need
> to look at the specifications and the code more closely and I don't know
> if/when I will find time to do this.
>
> Also I don't have any hardware to test this with NFC type 1 tags.
>
> >
> > Another thing regarding building the response message:
> > The following code snippet could simplify and improve the readability of the usage of the dbus message builder:
> >
> > dbus_message_iter_open_container(iter, DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE_AS_STRING, &entry);
> > dbus_message_iter_append_fixed_array(&entry, DBUS_TYPE_BYTE, &uid, len);
> > dbus_message_iter_close_container(iter, &entry);
> >
> Thanks for the improved code, I will use this instead.
>
> Frieder
Hi Frieder.
Do you have an updated version of this patch (or did I miss it)?
Thanks,
Mark
--
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
next prev parent reply other threads:[~2021-08-08 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 11:22 [linux-nfc] [PATCH v2] tag: Implement readout of tag UID via DBus interface Schrempf Frieder
[not found] ` <AM0P122MB011340CE87F73F55335D040C826B9@AM0P122MB0113.EURP122.PROD.OUTLOOK.COM>
2021-03-18 16:14 ` [linux-nfc] " Frieder Schrempf
2021-08-08 1:55 ` Mark Greer [this message]
2021-08-10 9:58 ` Frieder Schrempf
2021-08-20 15:31 ` Mark Greer
2021-03-16 18:49 Gottstein, Fabian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808015532.GE124928@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=frieder.schrempf@kontron.de \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).