linux-nfc.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Mark Greer <mgreer@animalcreek.com>
Cc: linux-nfc@lists.01.org
Subject: [linux-nfc] Re: [neard][PATCH 00/16] neard CI under Github and rouund of fixes
Date: Mon, 19 Jul 2021 10:04:40 +0200	[thread overview]
Message-ID: <6c5d40c7-3143-17a7-cc38-5f83f3c04ad1@canonical.com> (raw)
In-Reply-To: <20210719014045.GA705685@animalcreek.com>

On 19/07/2021 03:40, Mark Greer wrote:
> On Sat, Jul 10, 2021 at 05:38:43AM +0200, Krzysztof Kozlowski wrote:
>> Hi,
> 
> Hi Krzysztof
> 
>> Mark proposed to do some work around neard (the user-space counterpart
>> of NFC drivers) [1], so here it is.
>>
>> I made a fork on Github [2] and I add here Continuous Integration via
>> Github actions. These are pretty easy to set up. For starting only few
>> builds are done, but I have also more in the queue - just need to fix
>> 32-bit and clang builds.
>>
>> The neard fails to compile on GCC v10 (earlier maybe as well) in
>> maintainer moe (so with some warnings enabled) which is fixed here. It
>> is also first round of fixes around UTF-8 and UTF-16 parsing, although
>> this is not finished yet.
>>
>> Further plans:
>> 1. Decide whether official releases should be made from Github or
>>    kernel.org.
>> 2. Fix for clang.
>> 3. Fix UTF-8 and UTF-16 in ndef.
>> 4. Add more unit tests around ndef and others (help would be here
>>    appreciated).
>> 5. Add more GCC/clang warnings and fix them.
>> 6. Add some static analysis checks in Github CI.
>>
>> [1] https://lore.kernel.org/linux-nfc/20210512144319.30852-1-krzysztof.kozlowski@canonical.com/T/#m6a1cdae5f435b295cc7670c361b5bdc1daf30273
>> [2] https://github.com/krzk/neard
> 
> [This pertains to all of your patch sets that you've submitted.]
> 
> I started looking at these today but this patch series does not apply on
> top of the current neard master branch.  Also, there are CI patches
> intermingled with code-changing patches (and at least one patch that
> changes both (12th patch of second patch series).  Looking at your
> neard repository, there seems to be some patches in there that haven't
> been submitted via email.  Would you mind separating out CI patches from
> code patches (i.e., separate patch sets and email threads), ensuring
> that all patches are included, then re-submitting?

Sure, good point!


Best regards,
Krzysztof
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

      reply	other threads:[~2021-07-19  8:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10  3:38 [linux-nfc] [neard][PATCH 00/16] neard CI under Github and rouund of fixes Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 01/16] nfctool: fix adapter_compare_idx() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 02/16] nfctool: fix nfctool_send_dep_link_up() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 03/16] nfctool: fix nfctool_print_and_remove_snl() cast-function-type Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 04/16] ci: temporarily disable Ubuntu Hirsute Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 05/16] dbus: fix -Wformat in near_dbus_encode_string() Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 06/16] bootstrap: parse CROSS_COMPILE and set proper configure option Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 07/16] ci: add SPDX and copyright notes to ci.yml Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 08/16] ci: enable back Ubuntu Hirsute Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 09/16] ci: print executed commands when configuring debian Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 10/16] ci: no need to print twice compiler version Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 11/16] unit: pass real UTF-8 for testing text NDEF Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 12/16] ndef: check UTF-16 text payload length Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 13/16] ndef: silence clang -Wcast-align warning Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 14/16] ndef: fix parsing of UTF-16 text payload Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 15/16] nfctype5: fix returning uninitialized stack value in t5_tag_is_ti_pro() Krzysztof Kozlowski
2021-07-10  3:38 ` [linux-nfc] [neard][PATCH 16/16] ci: add clang builds Krzysztof Kozlowski
2021-07-19  1:40 ` [linux-nfc] Re: [neard][PATCH 00/16] neard CI under Github and rouund of fixes Mark Greer
2021-07-19  8:04   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c5d40c7-3143-17a7-cc38-5f83f3c04ad1@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=linux-nfc@lists.01.org \
    --cc=mgreer@animalcreek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).