From: "zhangxiaoxu (A)" <zhangxiaoxu5@huawei.com>
To: <trond.myklebust@hammerspace.com>, <nna.schumaker@netapp.com>,
<linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS4: Fix v4.0 client state corruption when mount
Date: Mon, 13 May 2019 09:48:26 +0800 [thread overview]
Message-ID: <066b843e-33cc-e8a3-ad2b-f8d257d8a4df@huawei.com> (raw)
In-Reply-To: <1557115023-86769-1-git-send-email-zhangxiaoxu5@huawei.com>
ping.
On 5/6/2019 11:57 AM, ZhangXiaoxu wrote:
> stat command with soft mount never return after server is stopped.
>
> When alloc a new client, the state of the client will be set to
> NFS4CLNT_LEASE_EXPIRED.
>
> When the server is stopped, the state manager will work, and accord
> the state to recover. But the state is NFS4CLNT_LEASE_EXPIRED, it
> will drain the slot table and lead other task to wait queue, until
> the client recovered. Then the stat command is hung.
>
> When discover server trunking, the client will renew the lease,
> but check the client state, it lead the client state corruption.
>
> So, we need to call state manager to recover it when detect server
> ip trunking.
>
> Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@huawei.com>
> ---
> fs/nfs/nfs4state.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index 3de3647..f502f1c 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -159,6 +159,10 @@ int nfs40_discover_server_trunking(struct nfs_client *clp,
> /* Sustain the lease, even if it's empty. If the clientid4
> * goes stale it's of no use for trunking discovery. */
> nfs4_schedule_state_renewal(*result);
> +
> + /* If the client state need to recover, do it. */
> + if (clp->cl_state)
> + nfs4_schedule_state_manager(clp);
> }
> out:
> return status;
>
next prev parent reply other threads:[~2019-05-13 1:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 3:57 [PATCH] NFS4: Fix v4.0 client state corruption when mount ZhangXiaoxu
2019-05-13 1:48 ` zhangxiaoxu (A) [this message]
2019-11-06 16:47 ` Benjamin Coddington
2019-11-07 2:34 ` zhangxiaoxu (A)
2019-11-07 13:25 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=066b843e-33cc-e8a3-ad2b-f8d257d8a4df@huawei.com \
--to=zhangxiaoxu5@huawei.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nna.schumaker@netapp.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).