From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Jan Psota <jasiu@belsznica.pl>
Subject: Re: refcount underflow in nfsd41_destroy_cb
Date: Tue, 31 Mar 2020 13:59:10 -0400 [thread overview]
Message-ID: <0B4E0C1C-58FF-43EB-BF68-E96BB9DCE664@oracle.com> (raw)
In-Reply-To: <6A4BC0CB-9A2F-405B-A7F7-5BFDA4FAD8CB@oracle.com>
Trond, any thoughts?
> On Mar 24, 2020, at 9:50 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
>
> Trond,
>
>> On Mar 23, 2020, at 11:09 AM, Jan Psota <jasiu@belsznica.pl> wrote:
>>
>>> I thought I read in the initial report that you were seeing this
>>> problem only on v5.6-rc6. What is the earliest kernel release
>>> where you saw refcount UaF warnings from nfsd4_destroy_cb?
>>>
>> I didn't noticed that earlier too, because until connection breakage on
>> WireGuard I did not have any problems related. But when you are asking,
>> I found it in my Pentium G2020 system too since 5.5.4 kernel and 5.4.2
>> looks not affected (I have logs since 01 Jan and fault begin to appear
>> on Feb 21, when I switched from 5.4.2 to 5.5.4 kernel a day before)
>>
>> $ journalctl | grep nfsd41_destroy_cb
>> lut 21 01:07:58 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> lut 27 01:01:12 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 03 00:59:01 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 03 23:03:02 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 11 11:52:42 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 13 01:12:02 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 14 14:31:39 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 15 20:56:56 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 17 15:58:32 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>> mar 22 15:24:03 mordimer kernel: nfsd41_destroy_cb+0x2c/0x40 [nfsd]
>>
>> I attach NFS part of my .config and a screen dump of menuconfig.
>> <nfs.config><nfs-config.txt>
>
> I'm wondering if
>
> 2bbfed98a4d8 ("nfsd: Fix races between nfsd4_cb_release() and nfsd4_shutdown_callback()")
>
> or
>
> 12357f1b2c8e ("nfsd: minor 4.1 callback cleanup")
>
> might be related to this issue (see down-thread for details and backtraces).
>
> --
> Chuck Lever
--
Chuck Lever
prev parent reply other threads:[~2020-03-31 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 2:51 refcount underflow in nfsd41_destroy_cb Jason A. Donenfeld
2020-03-21 14:41 ` Jan Psota
2020-03-21 17:25 ` Jan Psota
2020-05-10 23:23 ` Jan Psota
2020-05-15 22:01 ` J. Bruce Fields
2020-03-21 19:50 ` Chuck Lever
2020-03-22 3:43 ` Jan Psota
2020-03-23 14:13 ` Chuck Lever
2020-03-23 15:09 ` Jan Psota
2020-03-24 13:50 ` Chuck Lever
2020-03-31 17:59 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0B4E0C1C-58FF-43EB-BF68-E96BB9DCE664@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Jason@zx2c4.com \
--cc=jasiu@belsznica.pl \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).