From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE71C43387 for ; Thu, 3 Jan 2019 21:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5239217F5 for ; Thu, 3 Jan 2019 21:35:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Uz5p0x6J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbfACVfH (ORCPT ); Thu, 3 Jan 2019 16:35:07 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:58668 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727243AbfACVfH (ORCPT ); Thu, 3 Jan 2019 16:35:07 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x03LY0Ne177253; Thu, 3 Jan 2019 21:35:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=j9C7skNWBbJitu+jPJvV+0g2LEGxFhTXuMueMK6lJXw=; b=Uz5p0x6JUSYEfj1Q2uBBg7Zx8flsEcnyPhBn4W75ekot2cTD0pos7acmEBpZniP4YWMP Jb+kR/R+pndl9OCp1SPEg4c7U7btwdLuNdP/5X776z4jhAyV3XRCpPGQyQh16KDrwht0 n0mxYonCcsy5OCyqIGiPF3SF6ECu7IZdBRaGZ7gGEP6WfUmat3UodYYYx3AD/bAAqV1M bdmBPOJyO3sdSfvYX/8357h0WsxJUN6Y/4Re57rxOatwClDFtFvjmv+mzH1GFpsNzpNc mnP+hhc2eXq+yCa9df9MOUrr8CCMwryqBDQmXiwGAvog+8Rav4B3mqGGL+BBv30tATXd wA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2pnxee9g9y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Jan 2019 21:35:03 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x03LZ274023521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jan 2019 21:35:03 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x03LZ2PN017241; Thu, 3 Jan 2019 21:35:02 GMT Received: from anon-dhcp-121.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Jan 2019 13:35:02 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH] SUNRPC: Remove rpc_xprt::tsh_size From: Chuck Lever In-Reply-To: <076cce85045dbaab3ca40947b2599f96cff66b53.camel@hammerspace.com> Date: Thu, 3 Jan 2019 16:35:00 -0500 Cc: Linux NFS Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <1353EAC5-5BEE-461E-A11E-31F00FC7B946@oracle.com> References: <20190103182649.4148.19838.stgit@manet.1015granger.net> <0331de80b8161f8bf16a92de20049cafb0c228da.camel@hammerspace.com> <90B38E07-3241-4CCD-A4C8-AB78BADFB0CD@oracle.com> <791EE189-59E5-4D58-9CF6-6D2CFC6C1210@oracle.com> <076cce85045dbaab3ca40947b2599f96cff66b53.camel@hammerspace.com> To: Trond Myklebust X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9125 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=787 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901030185 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Jan 3, 2019, at 4:28 PM, Trond Myklebust = wrote: >=20 > On Thu, 2019-01-03 at 16:07 -0500, Chuck Lever wrote: >>> On Jan 3, 2019, at 3:53 PM, Chuck Lever >>> wrote: >>>=20 >>>> On Jan 3, 2019, at 1:47 PM, Trond Myklebust < >>>> trondmy@hammerspace.com> wrote: >>>>=20 >>>> On Thu, 2019-01-03 at 13:29 -0500, Chuck Lever wrote: >>>>> + reclen =3D req->rq_snd_buf.len; >>>>> + marker =3D cpu_to_be32(RPC_LAST_STREAM_FRAGMENT | >>>>> reclen); >>>>> + return kernel_sendmsg(transport->sock, &msg, &iov, 1, >>>>> iov.iov_len); >>>>=20 >>>> So what does this do for performance? I'd expect that adding >>>> another >>>> dive into the socket layer will come with penalties. >>>=20 >>> NFSv3 on TCP, sec=3Dsys, 56Gbs IBoIP, v4.20 + my v4.21 patches >>> fio, 8KB random, 70% read, 30% write, 16 threads, iodepth=3D16 >>>=20 >>> Without this patch: >>>=20 >>> read: IOPS=3D28.7k, BW=3D224MiB/s (235MB/s)(11.2GiB/51092msec) >>> write: IOPS=3D12.3k, BW=3D96.3MiB/s (101MB/s)(4918MiB/51092msec) >>>=20 >>> With this patch: >>>=20 >>> read: IOPS=3D28.6k, BW=3D224MiB/s (235MB/s)(11.2GiB/51276msec) >>> write: IOPS=3D12.3k, BW=3D95.8MiB/s (100MB/s)(4914MiB/51276msec) >>>=20 >>> Seems like that's in the noise. >>=20 >> Sigh. That's because it was the same kernel. Again, with feeling: >>=20 >> 4.20.0-rc7-00048-g9274254: >> read: IOPS=3D28.6k, BW=3D224MiB/s (235MB/s)(11.2GiB/51276msec) >> write: IOPS=3D12.3k, BW=3D95.8MiB/s (100MB/s)(4914MiB/51276msec) >>=20 >> 4.20.0-rc7-00049-ga4dea15: >> read: IOPS=3D27.2k, BW=3D212MiB/s (223MB/s)(11.2GiB/53979msec) >> write: IOPS=3D11.7k, BW=3D91.1MiB/s (95.5MB/s)(4917MiB/53979msec) >>=20 >=20 > So about a 5% reduction in performance? On this workload, yes. Could send the record marker in xs_send_kvec with the head[0] iovec. I'm going to try that next. -- Chuck Lever