linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <schumakeranna@gmail.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 0/2] NFSv4.2 umask support
Date: Fri, 28 Oct 2016 16:23:46 -0400	[thread overview]
Message-ID: <1477686228-12158-1-git-send-email-bfields@redhat.com> (raw)

From: "J. Bruce Fields" <bfields@redhat.com>

The following patches allow the umask to be ignored in the presence of
inheritable NFSv4 ACLs.  Otherwise inheritable ACLs can be rendered
mostly useless whenever the umask masks out group bits.

This solves a problem we've seen complaints about for some time, both
upstream and from RHEL users.

The new protocol has been discussed in the IETF working group and is
documented at:

	https://tools.ietf.org/html/draft-ietf-nfsv4-umask-02

It's unlikely that we'll discover problems requiring an incompatible
change, so I think we should consider this for 4.10.

--b.

Andreas Gruenbacher (2):
  nfs: add support for the umask attribute
  nfsd: add support for the umask attribute

 fs/nfs/dir.c              |  7 ++++++-
 fs/nfs/nfs4proc.c         | 21 ++++++++++++++++-----
 fs/nfs/nfs4xdr.c          | 36 ++++++++++++++++++++++++------------
 fs/nfsd/nfs4xdr.c         | 26 +++++++++++++++++++++-----
 fs/nfsd/nfsd.h            |  9 +++++++--
 fs/nfsd/nfssvc.c          |  4 ++--
 include/linux/nfs4.h      |  1 +
 include/linux/nfs_fs_sb.h |  1 +
 include/linux/nfs_xdr.h   |  2 ++
 9 files changed, 80 insertions(+), 27 deletions(-)

-- 
2.7.4


             reply	other threads:[~2016-10-28 20:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 20:23 J. Bruce Fields [this message]
2016-10-28 20:23 ` [PATCH 1/2] nfs: add support for the umask attribute J. Bruce Fields
2016-10-28 20:23 ` [PATCH 2/2] nfsd: " J. Bruce Fields
2016-10-28 20:28 ` [PATCH 0/2] NFSv4.2 umask support J. Bruce Fields
2016-10-29  9:38 ` Andreas Gruenbacher
2016-10-29 20:28   ` J. Bruce Fields
2016-10-29 22:10   ` Andreas Gruenbacher
2016-10-29 22:20 ` [PATCH 0/2] NFSv4.2 mode_umask support Andreas Gruenbacher
2016-10-30 13:59   ` J. Bruce Fields
2016-10-29 22:20 ` [PATCH 1/2] nfs: add support for the umask attribute Andreas Gruenbacher
2016-10-29 22:20 ` [PATCH 2/2] nfsd: " Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477686228-12158-1-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=agruenba@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=schumakeranna@gmail.com \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).