Linux-NFS Archive on
 help / color / Atom feed
From: Chuck Lever <>
Subject: [PATCH v1 1/6] xprtrdma: rpcrdma_mr_pop() already does list_del_init()
Date: Mon, 05 Apr 2021 12:34:53 -0400
Message-ID: <> (raw)
In-Reply-To: <>

The rpcrdma_mr_pop() earlier in the function has already cleared
out mr_list, so it must not be done again in the error path.

Fixes: 847568942f93 ("xprtrdma: Remove fr_state")
Signed-off-by: Chuck Lever <>
 net/sunrpc/xprtrdma/frwr_ops.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c
index 132df9b59ab4..aca2228095db 100644
--- a/net/sunrpc/xprtrdma/frwr_ops.c
+++ b/net/sunrpc/xprtrdma/frwr_ops.c
@@ -576,7 +576,6 @@ void frwr_unmap_sync(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req)
 		mr = container_of(frwr, struct rpcrdma_mr, frwr);
 		bad_wr = bad_wr->next;
-		list_del_init(&mr->mr_list);

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 16:34 [PATCH v1 0/6] More xprtrdma fixes Chuck Lever
2021-04-05 16:34 ` Chuck Lever [this message]
2021-04-05 16:34 ` [PATCH v1 2/6] xprtrdma: Rename frwr_release_mr() Chuck Lever
2021-04-05 16:35 ` [PATCH v1 3/6] xprtrdma: Clarify use of barrier in frwr_wc_localinv_done() Chuck Lever
2021-04-05 16:35 ` [PATCH v1 4/6] xprtrdma: Do not recycle MR after FastReg/LocalInv flushes Chuck Lever
2021-04-05 16:35 ` [PATCH v1 5/6] xprtrdma: Do not wake RPC consumer on a failed LocalInv Chuck Lever
2021-04-05 16:35 ` [PATCH v1 6/6] xprtrdma: Avoid Send Queue wrapping Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on

Archives are clonable:
	git clone --mirror linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ \
	public-inbox-index linux-nfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone