From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH RFC 0/5] Update RPC task pid as displayed by tracepoints
Date: Tue, 05 Oct 2021 13:13:58 -0400 [thread overview]
Message-ID: <163345354511.524558.1980332041837428746.stgit@morisot.1015granger.net> (raw)
Hi-
So based on Trond's earlier comment, this is what I've come up with.
These apply on top of the three patches Trond has already accepted.
I kind of wanted to do "task:%04x@%04x", but the "-1" still displays
as "ffffffff", so I left it as "task:%08x@%08x" to keep the fields
lined up in aligned columns. Any different ideas are welcome.
There are a couple of other fix-ups I found while working on this
update, and I've also included an optional patch to add the
nfs_readpage(s) tracepoints I found useful while tracking down
recent fsx failures.
---
Chuck Lever (5):
SUNRPC: Tracepoints should display tk_pid and cl_clid as a fixed-size field
SUNRPC: Avoid NULL pointer dereferences in tracepoints
SUNRPC: Use BIT() macro in rpc_show_xprt_state()
SUNRPC: Don't dereference xprt->snd_task if it's a cookie
NFS: Replace dprintk callsites in nfs_readpage(s)
fs/nfs/nfs4trace.h | 17 ++-
fs/nfs/nfstrace.h | 79 ++++++++++++-
fs/nfs/read.c | 8 +-
include/trace/events/rpcgss.h | 36 +++---
include/trace/events/rpcrdma.h | 104 +++++++----------
include/trace/events/sunrpc.h | 182 +++++++++++++----------------
include/trace/events/sunrpc_base.h | 42 +++++++
7 files changed, 265 insertions(+), 203 deletions(-)
create mode 100644 include/trace/events/sunrpc_base.h
--
Chuck Lever
next reply other threads:[~2021-10-05 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 17:13 Chuck Lever [this message]
2021-10-05 17:14 ` [PATCH RFC 1/5] SUNRPC: Tracepoints should display tk_pid and cl_clid as a fixed-size field Chuck Lever
2021-10-05 17:14 ` [PATCH RFC 2/5] SUNRPC: Avoid NULL pointer dereferences in tracepoints Chuck Lever
2021-10-05 17:14 ` [PATCH RFC 3/5] SUNRPC: Use BIT() macro in rpc_show_xprt_state() Chuck Lever
2021-10-05 17:14 ` [PATCH RFC 4/5] SUNRPC: Don't dereference xprt->snd_task if it's a cookie Chuck Lever
2021-10-05 17:14 ` [PATCH RFC 5/5] NFS: Replace dprintk callsites in nfs_readpage(s) Chuck Lever
2021-10-05 17:24 ` Chuck Lever III
[not found] ` <CALF+zOmKJTg-qx2J69QZAhG7KQOfra9noR5=bmaLfAFg1kZf-g@mail.gmail.com>
2021-10-07 15:01 ` Chuck Lever III
2021-10-07 15:25 ` David Wysochanski
2021-10-07 15:31 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163345354511.524558.1980332041837428746.stgit@morisot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).