From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trondmy@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] SUNRPC: Micro-optimisation to avoid call_bind+call_commit
Date: Tue, 5 Mar 2019 11:07:39 -0500 [thread overview]
Message-ID: <1DAB8293-359F-4409-81CD-E3F1A7ECDB93@oracle.com> (raw)
In-Reply-To: <20190305151722.45732-3-trond.myklebust@hammerspace.com>
> On Mar 5, 2019, at 10:17 AM, Trond Myklebust <trondmy@gmail.com> wrote:
>
> Most tasks should not have to deal with disconnected or unbound
> socket states, so let's move them out of the common state machine
> path.
Seems like a sensible idea. Were you able to measure any latency
improvement?
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> net/sunrpc/clnt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index c154684a35d4..b9251fd696ee 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -1806,7 +1806,7 @@ call_encode(struct rpc_task *task)
> xprt_request_enqueue_receive(task);
> xprt_request_enqueue_transmit(task);
> out:
> - task->tk_action = call_bind;
> + task->tk_action = call_transmit;
> }
>
> /*
> --
> 2.20.1
>
--
Chuck Lever
prev parent reply other threads:[~2019-03-05 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 15:17 [PATCH v2 1/3] SUNRPC: Prevent thundering herd when the socket is not connected Trond Myklebust
2019-03-05 15:17 ` [PATCH v2 2/3] SUNRPC: Fix up RPC back channel transmission Trond Myklebust
2019-03-05 15:17 ` [PATCH v2 3/3] SUNRPC: Micro-optimisation to avoid call_bind+call_commit Trond Myklebust
2019-03-05 16:07 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1DAB8293-359F-4409-81CD-E3F1A7ECDB93@oracle.com \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).