From: Trond Myklebust <trondmy@hammerspace.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>,
"lkp@intel.com" <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"bfields@redhat.com" <bfields@redhat.com>
Subject: Re: [PATCH] nfsd: Ensure CLONE persists data and metadata changes to the target file
Date: Sat, 30 Nov 2019 21:21:05 +0000 [thread overview]
Message-ID: <1b1218603c483b8bf9e703a8e2176d4d24024b39.camel@hammerspace.com> (raw)
In-Reply-To: <20191130195807.GA19460@fieldses.org>
On Sat, 2019-11-30 at 14:58 -0500, J. Bruce Fields wrote:
> On Fri, Nov 29, 2019 at 01:53:13AM +0800, kbuild test robot wrote:
> > fs//nfsd/vfs.c: In function 'nfsd4_clone_file_range':
> > > > fs//nfsd/vfs.c:540:5: error: 'commit_is_datasync' undeclared
> > > > (first use in this function); did you mean 'commit_metadata'?
> ...
> > 539 int status = vfs_fsync_range(dst,
> > dst_pos, dst_end,
> > > 540 commit_is_datasync);
>
> I've replaced commit_is_datasync by 0. Trond, correct me if I got
> that
> wrong.
Doh! Sorry about that. I blame ENOCOFFEE...
Thanks!
Trond
>
> --b.
>
> > 541 if (status < 0)
> > 542 return nfserrno(status);
> > 543 }
> > 544 return 0;
> > 545 }
> > 546
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source
> > Technology Center
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel
> > Corporation
>
>
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2019-11-30 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 22:05 [PATCH] nfsd: Ensure CLONE persists data and metadata changes to the target file Trond Myklebust
2019-11-27 22:22 ` J. Bruce Fields
2019-11-28 17:53 ` kbuild test robot
2019-11-30 19:58 ` J. Bruce Fields
2019-11-30 21:21 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b1218603c483b8bf9e703a8e2176d4d24024b39.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).