From: David Laight <David.Laight@ACULAB.COM>
To: 'Robert Milkowski' <rmilkowski@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
'Trond Myklebust' <trondmy@hammerspace.com>
Cc: 'Anna Schumaker' <anna.schumaker@netapp.com>,
'Chuck Lever' <chuck.lever@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
'Trond Myklebust' <trond.myklebust@hammerspace.com>
Subject: RE: [PATCH v4] NFSv4.0: nfs4_do_fsinfo() should not do implicit lease renewals
Date: Wed, 29 Jan 2020 15:35:18 +0000 [thread overview]
Message-ID: <1d098aa2dfea466a9aaa4c55353221e2@AcuMS.aculab.com> (raw)
In-Reply-To: <004e01d5d5ed$5e7ca490$1b75edb0$@gmail.com>
From: Robert Milkowski
> Sent: 28 January 2020 15:13
>
> Currently, each time nfs4_do_fsinfo() is called it will do an implicit
> NFS4 lease renewal, which is not compliant with the NFS4 specification.
> This can result in a lease being expired by an NFS server.
...
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 76d3716..7b2d88b 100644
...
> + if(status == 0)
Whitespace
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2020-01-29 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 15:12 [PATCH v4] NFSv4.0: nfs4_do_fsinfo() should not do implicit lease renewals Robert Milkowski
2020-01-28 15:42 ` Trond Myklebust
2020-01-28 16:02 ` Chuck Lever
2020-01-29 15:35 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d098aa2dfea466a9aaa4c55353221e2@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rmilkowski@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).