From: Steven Rostedt <rostedt@goodmis.org>
To: NeilBrown <neilb@suse.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4 v2] NFS: slight optimization for walking list for delegations
Date: Mon, 4 Jun 2018 17:31:41 -0400 [thread overview]
Message-ID: <20180604173141.0a154b80@gandalf.local.home> (raw)
In-Reply-To: <871sdsv1o5.fsf@notabene.neil.brown.name>
On Thu, 31 May 2018 15:23:22 +1000
NeilBrown <neilb@suse.com> wrote:
> There are 3 places where we walk the list of delegations
> for an nfs_client.
> In each case there are two nested loops, one for nfs_servers
> and one for nfs_delegations.
>
> When we find an interesting delegation we try to get an active
> reference to the server. If that fails, it is pointless to
> continue to look at the other delegation for the server as
> we will never be able to get an active reference.
> So instead of continuing in the inner loop, break out
> and continue in the outer loop.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>
> This time with a Signed-off-by - sorry.
> I took the opportunity to follow Steven's suggestion
> of adding a comment to the new 'break' statements.
>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2018-06-04 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 4:31 [PATCH 0/4 V2] Avoid quadratic search when freeing delegations NeilBrown
2018-04-30 4:31 ` [PATCH 3/4] rculist: add list_for_each_entry_from_rcu() NeilBrown
2018-04-30 5:20 ` Josh Triplett
2018-04-30 13:43 ` Paul E. McKenney
2018-04-30 15:14 ` Steven Rostedt
2018-04-30 15:35 ` Paul E. McKenney
2018-05-01 3:11 ` [PATCH 3/4 v2] " NeilBrown
2018-05-01 14:14 ` Paul E. McKenney
2018-05-01 21:34 ` NeilBrown
2018-04-30 4:31 ` [PATCH 1/4] NFS: slight optimization for walking list for delegations NeilBrown
2018-04-30 15:17 ` Steven Rostedt
2018-05-31 5:23 ` [PATCH 1/4 v2] " NeilBrown
2018-06-04 21:31 ` Steven Rostedt [this message]
2018-04-30 4:31 ` [PATCH 2/4] NFS: use cond_resched() when restarting walk of delegation list NeilBrown
2018-04-30 4:31 ` [PATCH 4/4] NFS: Avoid quadratic search when freeing delegations NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604173141.0a154b80@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).