From: Christoph Hellwig <hch@lst.de>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: bfields@fieldses.org, Jeff Layton <jlayton@kernel.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@lst.de>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: don't advertise a SCSI layout for an unsupported request_queue
Date: Tue, 19 Jun 2018 16:11:07 +0200 [thread overview]
Message-ID: <20180619141106.GB13089@lst.de> (raw)
In-Reply-To: <be316794f70ba6e4b2e0314cd6fca9ad2447cdc2.1529398437.git.bcodding@redhat.com>
On Tue, Jun 19, 2018 at 04:57:24AM -0400, Benjamin Coddington wrote:
> Commit 30181faae37f ("nfsd: Check queue type before submitting a SCSI
> request") did the work of ensuring that we don't send SCSI requests to a
> request queue that won't support them, but that check is in the
> GETDEVICEINFO path. Let's not set the SCSI layout in fs_layout_type in the
> first place, and then we'll have less clients sending GETDEVICEINFO for
> non-SCSI request queues and less unnecessary WARN_ONs.
>
> While we're in here, remove some outdated comments that refer to
> "overwriting" layout seletion because commit 8a4c3926889e ("nfsd: allow
> nfsd to advertise multiple layout types") changed things to no longer
> overwrite the layout type.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2018-06-19 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 8:57 [PATCH] nfsd: don't advertise a SCSI layout for an unsupported request_queue Benjamin Coddington
2018-06-19 13:55 ` J. Bruce Fields
2018-06-19 14:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619141106.GB13089@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).