From: Steve Dickson <steved@redhat.com>
To: Libtirpc-devel Mailing List <libtirpc-devel@lists.sourceforge.net>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 03/13] clnt_bcast.c: resource_leak
Date: Fri, 7 Sep 2018 14:01:41 -0400 [thread overview]
Message-ID: <20180907180151.178872-4-steved@redhat.com> (raw)
In-Reply-To: <20180907180151.178872-1-steved@redhat.com>
Variable "sys_auth" going out of scope leaks the storage it points to.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
src/clnt_bcast.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/clnt_bcast.c b/src/clnt_bcast.c
index 98cf061..2ad6c89 100644
--- a/src/clnt_bcast.c
+++ b/src/clnt_bcast.c
@@ -330,6 +330,7 @@ rpc_broadcast_exp(prog, vers, proc, xargs, argsp, xresults, resultsp,
if (nettype == NULL)
nettype = "datagram_n";
if ((handle = __rpc_setconf(nettype)) == NULL) {
+ AUTH_DESTROY(sys_auth);
return (RPC_UNKNOWNPROTO);
}
while ((nconf = __rpc_getconf(handle)) != NULL) {
--
2.17.1
next prev parent reply other threads:[~2018-09-07 22:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 18:01 [PATCH 00/13] libtirpc: Closed a number of memory leaks Steve Dickson
2018-09-07 18:01 ` [PATCH 01/13] auth_gss.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 02/13] auth_gss.c: buffer_size_warning Steve Dickson
2018-09-07 18:01 ` Steve Dickson [this message]
2018-09-07 18:01 ` [PATCH 04/13] clnt_vc.c: resource_leak Steve Dickson
2018-10-29 6:24 ` [Libtirpc-devel] " Ian Kent
2018-10-29 6:29 ` Ian Kent
2018-09-07 18:01 ` [PATCH 05/13] getnetconfig.c: cppcheck_warning Steve Dickson
2018-09-07 18:01 ` [PATCH 06/13] getnetpath.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 07/13] rpc_generic.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 08/13] rpc_soc.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 09/13] rpc_soc.c: buffer_size_warning Steve Dickson
2018-09-07 18:01 ` [PATCH 10/13] rpcb_clnt.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 11/13] rtime.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 12/13] svc_generic.c: resource_leak Steve Dickson
2018-09-07 18:01 ` [PATCH 13/13] svc_simple.c: resource_leak Steve Dickson
2018-09-11 16:00 ` [PATCH 00/13] libtirpc: Closed a number of memory leaks Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907180151.178872-4-steved@redhat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).