From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A73C65BAE for ; Thu, 13 Dec 2018 04:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C33AE20849 for ; Thu, 13 Dec 2018 04:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675742; bh=zO3u641QPifStiTZcCVvVMD/q/BIwZgstAI2hTjKiaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fHPoPqRiAmVVzZqIyu90zgG3V1swzdLfrKdaAcyVsoxJexjaYDLv1VjrjNa2Op5Ek AJbbAi1CupxXDg/cNamX8UNN3yM50+IaRrvfdPhJemfV0mKLL5RCC/+SB4Ijh5sDaD VTEMefqwUHIkrMxE8hLLAyGIO2yqooup5W15V1CY= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C33AE20849 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729461AbeLMEdy (ORCPT ); Wed, 12 Dec 2018 23:33:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:47026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729456AbeLMEdx (ORCPT ); Wed, 12 Dec 2018 23:33:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0363B20873; Thu, 13 Dec 2018 04:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675632; bh=zO3u641QPifStiTZcCVvVMD/q/BIwZgstAI2hTjKiaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ynBxtGl2tjXxua1bpOGa++VMys42g4Axb3psd1tpkU4mKnKr8Pbp6qx9JDz8OiAsv CWch1HW/BA9NVtLJvs5fbv6+ivyT9R2ywaALNK+xWhDcvkr11KsLZ8utLSCU+AKz45 WR9t94Uk1BCURgXRF/TyKHWivXprX5sBWYFnb3Ug= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuck Lever , stable@kernel.org, Trond Myklebust , Sasha Levin , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 05/16] SUNRPC: Fix leak of krb5p encode pages Date: Wed, 12 Dec 2018 23:33:32 -0500 Message-Id: <20181213043343.76896-5-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213043343.76896-1-sashal@kernel.org> References: <20181213043343.76896-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Chuck Lever [ Upstream commit 8dae5398ab1ac107b1517e8195ed043d5f422bd0 ] call_encode can be invoked more than once per RPC call. Ensure that each call to gss_wrap_req_priv does not overwrite pointers to previously allocated memory. Signed-off-by: Chuck Lever Cc: stable@kernel.org Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/auth_gss/auth_gss.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 81e29f02d28e..7a0e287be77f 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -1721,6 +1721,7 @@ priv_release_snd_buf(struct rpc_rqst *rqstp) for (i=0; i < rqstp->rq_enc_pages_num; i++) __free_page(rqstp->rq_enc_pages[i]); kfree(rqstp->rq_enc_pages); + rqstp->rq_release_snd_buf = NULL; } static int @@ -1729,6 +1730,9 @@ alloc_enc_pages(struct rpc_rqst *rqstp) struct xdr_buf *snd_buf = &rqstp->rq_snd_buf; int first, last, i; + if (rqstp->rq_release_snd_buf) + rqstp->rq_release_snd_buf(rqstp); + if (snd_buf->page_len == 0) { rqstp->rq_enc_pages_num = 0; return 0; -- 2.19.1