linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2019-01-15 21:38 Stephen Rothwell
  2019-01-15 21:41 ` Chuck Lever
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2019-01-15 21:38 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuck Lever,
	Paul Gortmaker

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

[I am experimenting with checking the Fixes tags in commits in linux-next.
Please let me know if you think I am being too strict.]

Hi all,

Commit

  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")

has problem with this Fixes tag:

  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")

The subject should match the subject of the fixed commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2019-05-30 21:58 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2019-05-30 21:58 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Olga Kornievskaia

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  ec6017d90359 ("SUNRPC fix regression in umount of a secure mount")

Fixes tag

  Fixes: c8485e4d63 ("SUNRPC: Handle ECONNREFUSED correctly in xprt_transmit()")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2019-10-21 20:48 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2019-10-21 20:48 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

In commit

  4609f9894ead ("SUNRPC: The TCP back channel mustn't disappear while requests are outstanding")

Fixes tag

  Fixes: 2ea24497a1b3 ("SUNRPC: RPC callbacks may be split across several..")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2020-05-19 18:30 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2020-05-19 18:30 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Olga Kornievskaia

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

In commit

  049a9d8a9117 ("NFSv4.1 fix rpc_call_done assignment for BIND_CONN_TO_SESSION")

Fixes tag

  Fixes: 02a95dee8 ("NFS add callback_ops to nfs4_proc_bind_conn_to_session_callback")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2020-06-26 23:01 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2020-06-26 23:01 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vasily Averin

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi all,

In commit

  b7ade38165ca ("sunrpc: fixed rollback in rpc_gssd_dummy_populate()")

Fixes tag

  Fixes: commit 4b9a445e3eeb ("sunrpc: create a new dummy pipe for gssd to hold open")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2022-02-06 20:56 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-02-06 20:56 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi all,

In commit

  677c0cebca78 ("NFS: Fix initialisation of nfs_client cl_flags field")

Fixes tag

  Fixes: 87871d990a2c ("NFSv4: Initialise connection to the server in nfs4_alloc_client()")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: dd99e9f98fbf ("NFSv4: Initialise connection to the server in nfs4_alloc_client()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2022-10-03 21:21 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-10-03 21:21 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Chuck Lever, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  a3569716d183 ("xprtrdma: Fix uninitialized variable")

Fixes tag

  Fixes: 6919549677909c ('xprtrdma: MR-related memory allocation should be allowed to fail')

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: d8cf39a280c3 ("xprtrdma: MR-related memory allocation should be allowed to fail")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* linux-next: Fixes tag needs some work in the nfs-anna tree
@ 2023-09-12 22:05 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2023-09-12 22:05 UTC (permalink / raw)
  To: Anna Schumaker, Trond Myklebust, NFS Mailing List
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  4788db30d973 ("NFS: Fix O_DIRECT locking issues")

Fixes tag

  Fixes: 0703dc52ef0b ("NFS: Fix error handling for O_DIRECT write scheduling")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 954998b60caa ("NFS: Fix error handling for O_DIRECT write scheduling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2023-09-12 22:06 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-15 21:38 linux-next: Fixes tag needs some work in the nfs-anna tree Stephen Rothwell
2019-01-15 21:41 ` Chuck Lever
2019-01-15 22:12   ` Takashi Iwai
2019-01-15 23:38     ` Paul Gortmaker
2019-01-16  6:32       ` Takashi Iwai
2019-01-16 15:24       ` Chuck Lever
2019-05-30 21:58 Stephen Rothwell
2019-10-21 20:48 Stephen Rothwell
2020-05-19 18:30 Stephen Rothwell
2020-06-26 23:01 Stephen Rothwell
2022-02-06 20:56 Stephen Rothwell
2022-10-03 21:21 Stephen Rothwell
2023-09-12 22:05 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).