linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires=
@ 2019-01-25  8:33 Yongcheng Yang
  2019-01-25 16:44 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Yongcheng Yang @ 2019-01-25  8:33 UTC (permalink / raw)
  To: Steve Dickson; +Cc: linux-nfs, Yongcheng Yang

The rpc_pipefs.target should enter inactive state if
var-lib-nfs-rpc_pipefs.mount is stopped. Otherwise,
services depending rpc_pipefs.target (e.g. nfs-idmapd)
fail to start after /var/lib/nfs/rpc_pipefs unmounted

Signed-off-by: Yongcheng Yang <yongcheng.yang@gmail.com>
---

Reproducing steps:
$ systemctl stop nfs-idmapd
$ umount /var/lib/nfs/rpc_pipefs
$ systemctl start nfs-idmapd

Thanks,
Yongcheng

 systemd/rpc_pipefs.target | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemd/rpc_pipefs.target b/systemd/rpc_pipefs.target
index 01d4d27..5ce3981 100644
--- a/systemd/rpc_pipefs.target
+++ b/systemd/rpc_pipefs.target
@@ -1,3 +1,3 @@
 [Unit]
-Requires=var-lib-nfs-rpc_pipefs.mount
+BindsTo=var-lib-nfs-rpc_pipefs.mount
 After=var-lib-nfs-rpc_pipefs.mount
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires=
  2019-01-25  8:33 [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires= Yongcheng Yang
@ 2019-01-25 16:44 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2019-01-25 16:44 UTC (permalink / raw)
  To: Yongcheng Yang; +Cc: linux-nfs

Hello Yongcheng,

On 1/25/19 3:33 AM, Yongcheng Yang wrote:
> The rpc_pipefs.target should enter inactive state if
> var-lib-nfs-rpc_pipefs.mount is stopped. Otherwise,
> services depending rpc_pipefs.target (e.g. nfs-idmapd)
> fail to start after /var/lib/nfs/rpc_pipefs unmounted
> 
> Signed-off-by: Yongcheng Yang <yongcheng.yang@gmail.com>
> ---
> 
> Reproducing steps:
> $ systemctl stop nfs-idmapd
> $ umount /var/lib/nfs/rpc_pipefs
> $ systemctl start nfs-idmapd
I look at things like this and I think there real
fix here is... Just don't do that! :-) 

Now I'm sure the patch works... but... why in the world would anybody 
unmount /var/lib/nfs/rpc_pipefs with NFS daemons running? 

Unless you are some mad QA person trying to destroy the world! ;-) 

steved.
> 
> Thanks,
> Yongcheng
> 
>  systemd/rpc_pipefs.target | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/systemd/rpc_pipefs.target b/systemd/rpc_pipefs.target
> index 01d4d27..5ce3981 100644
> --- a/systemd/rpc_pipefs.target
> +++ b/systemd/rpc_pipefs.target
> @@ -1,3 +1,3 @@
>  [Unit]
> -Requires=var-lib-nfs-rpc_pipefs.mount
> +BindsTo=var-lib-nfs-rpc_pipefs.mount
>  After=var-lib-nfs-rpc_pipefs.mount
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-25 16:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25  8:33 [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires= Yongcheng Yang
2019-01-25 16:44 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).