From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>, simo@redhat.com
Subject: Re: [PATCH RFC 09/10] SUNRPC: Remove xdr_buf_trim()
Date: Mon, 4 Feb 2019 15:11:45 -0500 [thread overview]
Message-ID: <20190204201145.GF1816@fieldses.org> (raw)
In-Reply-To: <BB18AC3C-0EAA-4E63-9C87-5377070D1F4E@oracle.com>
On Mon, Feb 04, 2019 at 03:07:26PM -0500, Chuck Lever wrote:
>
>
> > On Feb 4, 2019, at 3:00 PM, Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Mon, Feb 04, 2019 at 02:49:11PM -0500, Chuck Lever wrote:
> >>
> >>
> >>> On Feb 4, 2019, at 2:46 PM, bfields@fieldses.org wrote:
> >>>
> >>> On Fri, Feb 01, 2019 at 02:58:14PM -0500, Chuck Lever wrote:
> >>>> The key action of xdr_buf_trim() is that it shortens buf->len, the
> >>>> length of the xdr_buf' content. The other actions -- shortening the
> >>>> head, pages, and tail components -- are actually not necessary. In
> >>>> some cases, changing the size of those components corrupts the RPC
> >>>> message contained in the buffer.
> >>>
> >>> That's really burying the lede.... Is there an actual user-visible bug
> >>> here?
> >>
> >> I don't think so. This is more of the form:
> >>
> >> a) the function does fundamentally the wrong thing, so
> >>
> >> b) certain changes to this code path result is unexpected and incorrect
> >> behavior
> >>
> >> Thus typically only developers hacking on this code run into a problem.
> >
> > OK, got it. It'd help just to make it clear in the changelog that that
> > this is an accident waiting to happen rather than a current bug (as far
> > as we know).
>
> With said improvement to the changelog, can I add your Acked-by
> when I submit this through Anna's tree?
Sure, thanks.
--b.
next prev parent reply other threads:[~2019-02-04 20:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 19:57 [PATCH RFC 00/10] SUNRPC GSS overhaul Chuck Lever
2019-02-01 19:57 ` [PATCH RFC 01/10] SUNRPC: Remove some dprintk() call sites from auth functions Chuck Lever
2019-02-04 19:04 ` J. Bruce Fields
2019-02-04 19:07 ` Chuck Lever
2019-02-01 19:57 ` [PATCH RFC 02/10] SUNRPC: Remove rpc_xprt::tsh_size Chuck Lever
2019-02-01 19:57 ` [PATCH RFC 03/10] SUNRPC: Add build option to disable support for insecure enctypes Chuck Lever
2019-02-01 19:57 ` [PATCH RFC 04/10] SUNRPC: Add common byte-swapped RPC header constants Chuck Lever
2019-02-02 2:30 ` Tom Talpey
2019-02-02 22:46 ` Chuck Lever
2019-02-03 15:00 ` Trond Myklebust
2019-02-03 16:49 ` Chuck Lever
2019-02-03 18:58 ` Trond Myklebust
2019-02-02 17:02 ` Christoph Hellwig
2019-02-02 22:49 ` Chuck Lever
2019-02-04 7:53 ` Christoph Hellwig
2019-02-04 14:16 ` Chuck Lever
2019-02-04 14:32 ` Christoph Hellwig
2019-02-04 14:56 ` Chuck Lever
2019-02-04 19:37 ` J. Bruce Fields
2019-02-05 1:57 ` Tom Talpey
2019-02-01 19:57 ` [PATCH RFC 05/10] SUNRPC: Use struct xdr_stream when constructing RPC Call header Chuck Lever
2019-02-01 19:57 ` [PATCH RFC 06/10] SUNRPC: Clean up rpc_verify_header() Chuck Lever
2019-02-01 19:58 ` [PATCH RFC 07/10] SUNRPC: Use struct xdr_stream when decoding RPC Reply header Chuck Lever
2019-02-01 19:58 ` [PATCH RFC 08/10] SUNRPC: Introduce trace points in rpc_auth_gss.ko Chuck Lever
2019-02-01 19:58 ` [PATCH RFC 09/10] SUNRPC: Remove xdr_buf_trim() Chuck Lever
2019-02-04 19:46 ` J. Bruce Fields
2019-02-04 19:49 ` Chuck Lever
2019-02-04 20:00 ` Bruce Fields
2019-02-04 20:07 ` Chuck Lever
2019-02-04 20:11 ` Bruce Fields [this message]
2019-02-01 19:58 ` [PATCH RFC 10/10] SUNRPC: Add SPDX IDs to some net/sunrpc/auth_gss/ files Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204201145.GF1816@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).