From: Salvatore Bonaccorso <carnil@debian.org>
To: Donald Buczek <buczek@molgen.mpg.de>
Cc: stable@vger.kernel.org, linux-nfs@vger.kernel.org, bfields@fieldses.org
Subject: Re: [PATCH 4.14 0/2] Two nfsd4 fixes for 4.14 longterm
Date: Tue, 5 Feb 2019 12:59:48 +0100 [thread overview]
Message-ID: <20190205115948.azdwswkyetbop56r@lorien.valinor.li> (raw)
In-Reply-To: <20190205100141.25304-1-buczek@molgen.mpg.de>
Hi Donald,
On Tue, Feb 05, 2019 at 11:01:39AM +0100, Donald Buczek wrote:
> Please include the upstream patches
>
> * commit 085def3ade52 ("nfsd4: fix cached replies to solo SEQUENCE
> compounds")
> * commit 53da6a53e1d4 ("nfsd4: catch some false session retries")
>
> into longterm kernel 4.14.
>
> Because these patches went upstream in 4.15, they are already
> included in longterm 4.19 and stable.
>
> A nfsd4 server failure, where the server sends unrelated replies
> to client requests containing only SEQUENCE operations has been
> experienced with kernel version 4.14.87 [1]. Because the client
> retries endlessly, this completely breaks the nfs mount.
>
> A backport of these patches has been suggested by the patch
> author J. Bruce Fields. [1]
>
> Only limited testing has been done (running a single server with
> 4.14.96 and these two patches for a week and generating some high
> load on it). It can not be proven by testing, that the patches
> really fix the experienced problem. However, as the patches are
> part of upstream and stable kernels for over a year
> they should be a save pick.
>
> Backport note: Only line numbers updated.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=202435
>
> J. Bruce Fields (2):
> nfsd4: fix cached replies to solo SEQUENCE compounds
> nfsd4: catch some false session retries
Are you planning to submit the same as well for 4.9 LTS? The two
commits apply on top of 4.9.154 with line number updated.
Regards,
Salvatore
next prev parent reply other threads:[~2019-02-05 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 10:01 [PATCH 4.14 0/2] Two nfsd4 fixes for 4.14 longterm Donald Buczek
2019-02-05 10:01 ` [PATCH 4.14 1/2] nfsd4: fix cached replies to solo SEQUENCE compounds Donald Buczek
2019-02-05 10:01 ` [PATCH 4.14 2/2] nfsd4: catch some false session retries Donald Buczek
2019-02-05 11:59 ` Salvatore Bonaccorso [this message]
2019-02-05 14:59 ` [PATCH 4.14 0/2] Two nfsd4 fixes for 4.14 longterm Donald Buczek
2019-02-11 13:34 ` Greg KH
2019-02-11 15:59 ` Salvatore Bonaccorso
2019-02-13 6:49 ` Salvatore Bonaccorso
2019-02-13 14:15 ` Greg KH
2019-02-05 21:31 ` J. Bruce Fields
2019-02-11 13:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205115948.azdwswkyetbop56r@lorien.valinor.li \
--to=carnil@debian.org \
--cc=bfields@fieldses.org \
--cc=buczek@molgen.mpg.de \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).