From: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Subject: [PATCH] st_getattr: do not expect server to return rdattr_error
Date: Fri, 8 Feb 2019 18:18:08 +0100 [thread overview]
Message-ID: <20190208171808.7861-1-tigran.mkrtchyan@desy.de> (raw)
rfc7530:
5.8.1.12. Attribute 11: rdattr_error
Error returned from an attempt to retrieve attributes during a
READDIR operation.
IOW, we do not expect rdattr_error to be returned in reply to regular
GETATTR operation.
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
---
nfs4.0/servertests/st_getattr.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/nfs4.0/servertests/st_getattr.py b/nfs4.0/servertests/st_getattr.py
index 292fcd2..1c47ebf 100644
--- a/nfs4.0/servertests/st_getattr.py
+++ b/nfs4.0/servertests/st_getattr.py
@@ -1,12 +1,14 @@
from xdrdef.nfs4_const import *
from .environment import check
-from nfs4lib import get_attr_name
+from nfs4lib import get_attr_name, get_attrbitnum_dict
import nfs_ops
op = nfs_ops.NFS4ops()
def _try_mandatory(t, env, path):
c = env.c1
mandatory = [attr.bitnum for attr in env.attr_info if attr.mandatory]
+ # don't expect rdattr_error to be a part of returned attributes
+ mandatory.remove(get_attrbitnum_dict()['rdattr_error'])
ops = c.use_obj(path)
ops += [c.getattr(mandatory)]
res = c.compound(ops)
--
2.20.1
next reply other threads:[~2019-02-08 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 17:18 Tigran Mkrtchyan [this message]
2019-02-14 17:11 ` [PATCH] st_getattr: do not expect server to return rdattr_error J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208171808.7861-1-tigran.mkrtchyan@desy.de \
--to=tigran.mkrtchyan@desy.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).