On Wed, Feb 27, 2019 at 12:16:18PM -0500, Steve Dickson wrote:
> 
> 
> On 2/4/19 9:31 AM, Patrick Steinhardt wrote:
> > The macro HAVE_GETRPCBYNUMBER_R is set based on whether the
> > `getrpcbynumber_r` function was found by autoconf or not. While another
> > location correctly checks whether it is set by using `#ifdef`,
> > `getservport()` instead wrongly uses `#if HAVE_GETRPCBYNUMBER_R`. This
> > may cause a compilation error with gcc with "-Werror=undef" if the macro
> > has not been defined.
> > 
> > Fix the error by using `#ifdef` instead.
> > 
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> Committed...
> 
> BTW... If the future, feel free to ping me it appears 
> patches slide off my radar... like these did... ;-( 
> 
> steved.

Will do. I know from my own experience that it's hard to keep
track and be able to always respond in time :)

So thanks for your review and for committing them.

Patrick