From: Yongcheng Yang <yongcheng.yang@gmail.com>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs@vger.kernel.org, Yongcheng Yang <yongcheng.yang@gmail.com>
Subject: [PATCH] nfs-utils: nfsidmap fail to build if no --with-pluginpath specified
Date: Tue, 2 Apr 2019 17:16:51 +0800 [thread overview]
Message-ID: <20190402091651.17186-1-yongcheng.yang@gmail.com> (raw)
The var "pkgplugindir" will be empty if no pluginpath provided.
Makefile "-rpath $(pkgplugindir)" will then get failed.
Signed-off-by: Yongcheng Yang <yongcheng.yang@gmail.com>
---
support/nfsidmap/Makefile.am | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/support/nfsidmap/Makefile.am b/support/nfsidmap/Makefile.am
index cdbeb4c..9c21fa3 100644
--- a/support/nfsidmap/Makefile.am
+++ b/support/nfsidmap/Makefile.am
@@ -1,4 +1,8 @@
+if PATH_PLUGINS
pkgplugindir=$(PATH_PLUGINS)
+else
+pkgplugindir=$(libdir)/libnfsidmap
+endif
if ENABLE_LDAP
UMICH_LDAP_LIB = umich_ldap.la
--
2.17.2
next reply other threads:[~2019-04-02 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 9:16 Yongcheng Yang [this message]
2019-04-02 9:26 ` [PATCH] nfs-utils: nfsidmap fail to build if no --with-pluginpath specified Yongcheng Yang
2019-04-16 14:34 ` Steve Dickson
2019-04-17 9:22 ` Yongcheng Yang
2019-05-10 18:49 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402091651.17186-1-yongcheng.yang@gmail.com \
--to=yongcheng.yang@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).