From: "J. Bruce Fields" <bfields@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: Doug Nazar <nazard@nazar.ca>, linux-nfs@vger.kernel.org
Subject: Re: nfsd bug after f875a792abe9 (nfsd: allow nfsv3 readdir request to be larger.)
Date: Tue, 23 Apr 2019 10:38:48 -0400 [thread overview]
Message-ID: <20190423143848.GA9302@parsley.fieldses.org> (raw)
In-Reply-To: <87tvep6066.fsf@notabene.neil.brown.name>
On Tue, Apr 23, 2019 at 10:21:53AM +1000, NeilBrown wrote:
> On Sat, Apr 20 2019, Doug Nazar wrote:
>
> > After recently upgrading the kernel on one of my servers I was getting
> > the below crashes. Tracked it down to an NFSv3 root client, bisection
> > points to f875a792abe9. A revert of that on top of
> > 5.1.0-rc5-00289-gee2725f711fa works fine.
>
> hi Doug,
> thanks for the report and for bisecting!
>
> I think this bug has been fixed, but the fix hasn't landed upstream yet.
> If you
> git pull git://git.linux-nfs.org/~bfields/linux.git nfs-next
>
> you should get
>
> Commit 3c86794ac0e6 ("nfsd/nfsd3_proc_readdir: fix buffer count and page pointers")
>
> which should fix this.
>
>
> Bruce: I don't see that patch in your "for-5.1" branch, but you said
> "Queuing up for 5.1."
> Did something go awry?
Sorry, I've got this confusing system where I commit first to a branch
named for-x.y-incoming, then push it to for-x.y after I've tested it.
Except sometimes I forget to push to the for-x.y branch until the last
minute.
The -incoming branches should always be included in nfsd-next.
Anyway, I'll send a pull request now, it's overdue....
--b.
prev parent reply other threads:[~2019-04-23 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 3:36 nfsd bug after f875a792abe9 (nfsd: allow nfsv3 readdir request to be larger.) Doug Nazar
2019-04-23 0:21 ` NeilBrown
2019-04-23 2:22 ` Doug Nazar
2019-04-23 14:38 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423143848.GA9302@parsley.fieldses.org \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nazard@nazar.ca \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).