Linux-NFS Archive on lore.kernel.org
 help / color / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 00/19] Covertity Scan: Removed resources leaks
Date: Wed,  8 May 2019 09:35:17 -0400
Message-ID: <20190508133536.6077-1-steved@redhat.com> (raw)

Red Hat is now requiring covertity scans 
to be run against all RHEL 8 packages. 

These patches removed the majority of the 
resource leaks that were flagged by the scan.

Most of the leaks were in return and error
paths as well as some obvious problems like
checking the wrong point to be NULL. 

There are still a few resources leaks 
and used_after_freed being flagged but
I am thinking they false-positives 
because I just don't see the problem. 

I've tested these patches for a couple
days and they seem stable... but whenever
free()s are added... So is risk of freeing
that is still being used. Plus they will
get a good workout at the upcoming Bakeathon.

Steve Dickson (19):
  Removed resource leaks from junction/path.c
  Removed resource leaks from nfs/exports.c
  Removed a resource leak from nfs/mydaemon.c
  Removed a resource leak from nfs/rpcmisc.c
  Removed a resource leak from nfs/svc_socket.c
  Removed bad frees from nfs/xcommon.c
  Removed resource leaks from nfs/xlog.c
  Removed resource leaks from nfsidmap/libnfsidmap.c
  Removed resource leaks from nfsidmap/static.c
  Removed a resource leak from nsm/file.c
  Removed resource leaks from systemd/rpc-pipefs-generator.c
  Removed resource leaks from blkmapd/device-discovery.c
  Removed resource leaks from gssd/krb5_util.c
  Removed a resource leak from mount/configfile.c
  Removed a resource leak from mount/nfsmount.c
  Removed a resource leak from mount/stropts.c
  Removed resource leaks from mountd/cache.c
  Removed a resource leak from mountd/fsloc.c
  Removed a resource leak from nfsdcltrack/sqlite.c

 support/junction/path.c          |  6 +++++-
 support/nfs/exports.c            |  2 ++
 support/nfs/mydaemon.c           |  1 +
 support/nfs/rpcmisc.c            |  1 +
 support/nfs/svc_socket.c         |  1 +
 support/nfs/xcommon.c            | 14 ++++++++++----
 support/nfs/xlog.c               |  6 +++++-
 support/nfsidmap/libnfsidmap.c   | 10 ++++++++--
 support/nfsidmap/static.c        | 10 ++++++++++
 support/nsm/file.c               |  1 +
 systemd/rpc-pipefs-generator.c   | 10 ++++++++--
 utils/blkmapd/device-discovery.c | 22 +++++++++++++++++++++-
 utils/gssd/krb5_util.c           |  9 ++++++++-
 utils/mount/configfile.c         |  2 +-
 utils/mount/nfsmount.c           |  1 +
 utils/mount/stropts.c            |  5 ++++-
 utils/mountd/cache.c             |  5 +++--
 utils/mountd/fsloc.c             |  1 +
 utils/nfsdcltrack/sqlite.c       |  2 ++
 19 files changed, 93 insertions(+), 16 deletions(-)

-- 
2.20.1


             reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 13:35 Steve Dickson [this message]
2019-05-08 13:35 ` [PATCH 01/19] Removed resource leaks from junction/path.c Steve Dickson
2019-05-08 13:35 ` [PATCH 02/19] Removed resource leaks from nfs/exports.c Steve Dickson
2019-05-08 13:35 ` [PATCH 03/19] Removed a resource leak from nfs/mydaemon.c Steve Dickson
2019-05-08 13:35 ` [PATCH 04/19] Removed a resource leak from nfs/rpcmisc.c Steve Dickson
2019-05-08 13:35 ` [PATCH 05/19] Removed a resource leak from nfs/svc_socket.c Steve Dickson
2019-05-08 13:35 ` [PATCH 06/19] Removed bad frees from nfs/xcommon.c Steve Dickson
2019-05-08 13:35 ` [PATCH 07/19] Removed resource leaks from nfs/xlog.c Steve Dickson
2019-05-08 13:35 ` [PATCH 08/19] Removed resource leaks from nfsidmap/libnfsidmap.c Steve Dickson
2019-05-08 13:35 ` [PATCH 09/19] Removed resource leaks from nfsidmap/static.c Steve Dickson
2019-05-08 13:35 ` [PATCH 10/19] Removed a resource leak from nsm/file.c Steve Dickson
2019-05-08 13:35 ` [PATCH 11/19] Removed resource leaks from systemd/rpc-pipefs-generator.c Steve Dickson
2019-05-08 13:35 ` [PATCH 12/19] Removed resource leaks from blkmapd/device-discovery.c Steve Dickson
2019-05-08 13:35 ` [PATCH 13/19] Removed resource leaks from gssd/krb5_util.c Steve Dickson
2019-05-08 13:35 ` [PATCH 14/19] Removed a resource leak from mount/configfile.c Steve Dickson
2019-05-08 13:35 ` [PATCH 15/19] Removed a resource leak from mount/nfsmount.c Steve Dickson
2019-05-08 13:35 ` [PATCH 16/19] Removed a resource leak from mount/stropts.c Steve Dickson
2019-05-08 13:35 ` [PATCH 17/19] Removed resource leaks from mountd/cache.c Steve Dickson
2019-05-08 13:35 ` [PATCH 18/19] Removed a resource leak from mountd/fsloc.c Steve Dickson
2019-05-08 13:35 ` [PATCH 19/19] Removed a resource leak from nfsdcltrack/sqlite.c Steve Dickson
2019-05-10 15:07 ` [PATCH 00/19] Covertity Scan: Removed resources leaks Steve Dickson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508133536.6077-1-steved@redhat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \
		linux-nfs@vger.kernel.org linux-nfs@archiver.kernel.org
	public-inbox-index linux-nfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox