From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C86C04AAD for ; Wed, 8 May 2019 13:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 841A3204FD for ; Wed, 8 May 2019 13:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727271AbfEHNfr (ORCPT ); Wed, 8 May 2019 09:35:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727370AbfEHNfr (ORCPT ); Wed, 8 May 2019 09:35:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B6E33087951 for ; Wed, 8 May 2019 13:35:47 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14F021724D for ; Wed, 8 May 2019 13:35:47 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 14/19] Removed a resource leak from mount/configfile.c Date: Wed, 8 May 2019 09:35:31 -0400 Message-Id: <20190508133536.6077-15-steved@redhat.com> In-Reply-To: <20190508133536.6077-1-steved@redhat.com> References: <20190508133536.6077-1-steved@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 08 May 2019 13:35:47 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org mount/configfile.c:410: leaked_storage: Variable "config_opts" going out of scope leaks the storage it points to. Signed-off-by: Steve Dickson --- utils/mount/configfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/mount/configfile.c b/utils/mount/configfile.c index b48b25e..93fe500 100644 --- a/utils/mount/configfile.c +++ b/utils/mount/configfile.c @@ -404,7 +404,7 @@ char *conf_get_mntopts(char *spec, char *mount_point, /* list_size + optlen + ',' + '\0' */ config_opts = calloc(1, (list_size+optlen+2)); - if (server == NULL) { + if (config_opts == NULL) { xlog_warn("conf_get_mountops: Unable calloc memory for config_opts"); free_all(); return mount_opts; -- 2.20.1