From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH RFC] svcrdma: Ignore source port when computing DRC hash
Date: Wed, 05 Jun 2019 08:15:18 -0400 [thread overview]
Message-ID: <20190605121518.2150.26479.stgit@klimt.1015granger.net> (raw)
The DRC is not working at all after an RPC/RDMA transport reconnect.
The problem is that the new connection uses a different source port,
which defeats DRC hash.
An NFS/RDMA client's source port is meaningless for RDMA transports.
The transport layer typically sets the source port value on the
connection to a random ephemeral port. The server already ignores it
for the "secure port" check. See commit 16e4d93f6de7 ("NFSD: Ignore
client's source port on RDMA transports").
I'm not sure why I never noticed this before.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org
---
net/sunrpc/xprtrdma/svc_rdma_transport.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index 027a3b0..1b3700b 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -211,9 +211,14 @@ static void handle_connect_req(struct rdma_cm_id *new_cma_id,
/* Save client advertised inbound read limit for use later in accept. */
newxprt->sc_ord = param->initiator_depth;
- /* Set the local and remote addresses in the transport */
sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr;
svc_xprt_set_remote(&newxprt->sc_xprt, sa, svc_addr_len(sa));
+ /* The remote port is arbitrary and not under the control of the
+ * ULP. Set it to a fixed value so that the DRC continues to work
+ * after a reconnect.
+ */
+ rpc_set_port((struct sockaddr *)&newxprt->sc_xprt.xpt_remote, 0);
+
sa = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr;
svc_xprt_set_local(&newxprt->sc_xprt, sa, svc_addr_len(sa));
next reply other threads:[~2019-06-05 12:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 12:15 Chuck Lever [this message]
2019-06-05 15:57 ` [PATCH RFC] svcrdma: Ignore source port when computing DRC hash Olga Kornievskaia
2019-06-05 17:28 ` Chuck Lever
2019-06-06 18:13 ` Olga Kornievskaia
2019-06-06 18:33 ` Chuck Lever
2019-06-07 15:43 ` Olga Kornievskaia
2019-06-10 14:38 ` Tom Talpey
2019-06-05 16:43 ` Tom Talpey
2019-06-05 17:25 ` Chuck Lever
2019-06-10 14:50 ` Tom Talpey
2019-06-10 17:50 ` Chuck Lever
2019-06-10 19:14 ` Tom Talpey
2019-06-10 21:57 ` Chuck Lever
2019-06-10 22:13 ` Tom Talpey
2019-06-11 0:07 ` Tom Talpey
2019-06-11 14:25 ` Chuck Lever
2019-06-11 14:23 ` Chuck Lever
2019-06-06 13:08 ` Sasha Levin
2019-06-06 13:24 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605121518.2150.26479.stgit@klimt.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).