From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51201C433FF for ; Thu, 1 Aug 2019 20:01:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FCC4206B8 for ; Thu, 1 Aug 2019 20:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388957AbfHAUBC (ORCPT ); Thu, 1 Aug 2019 16:01:02 -0400 Received: from fieldses.org ([173.255.197.46]:44390 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388766AbfHAUBC (ORCPT ); Thu, 1 Aug 2019 16:01:02 -0400 Received: by fieldses.org (Postfix, from userid 2815) id E24AF7CB; Thu, 1 Aug 2019 16:01:01 -0400 (EDT) Date: Thu, 1 Aug 2019 16:01:01 -0400 From: "J. Bruce Fields" To: Tigran Mkrtchyan Cc: linux-nfs@vger.kernel.org, Tom Haynes Subject: Re: [PATCH] st_flex: fix uid/gid formatting in error message Message-ID: <20190801200101.GB21527@fieldses.org> References: <20190722141602.14274-1-tigran.mkrtchyan@desy.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190722141602.14274-1-tigran.mkrtchyan@desy.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jul 22, 2019 at 04:16:02PM +0200, Tigran Mkrtchyan wrote: > as ffds_user and ffds_group are utf8 encoded string use '%s' when > constructing an error message. Thanks, applied--sorry for being slow to get to this. --b. > > Signed-off-by: Tigran Mkrtchyan > --- > nfs4.1/server41tests/st_flex.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex.py > index 335b2c8..f4ac739 100644 > --- a/nfs4.1/server41tests/st_flex.py > +++ b/nfs4.1/server41tests/st_flex.py > @@ -313,10 +313,10 @@ def testFlexLayoutTestAccess(t, env): > gid_rd = ds.ffds_group > > if uid_rw == uid_rd: > - fail("Expected uid_rd != %i, got %i" % (uid_rd, uid_rw)) > + fail("Expected uid_rd != %s, got %s" % (uid_rd, uid_rw)) > > if gid_rw != gid_rd: > - fail("Expected gid_rd == %i, got %i" % (gid_rd, gid_rw)) > + fail("Expected gid_rd == %s, got %s" % (gid_rd, gid_rw)) > > res = close_file(sess, fh, stateid=open_stateid) > check(res) > -- > 2.21.0