From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E45B4C433FF for ; Sat, 3 Aug 2019 07:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA19A2166E for ; Sat, 3 Aug 2019 07:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564816024; bh=fAm+JJVlEEdZsZEnQU6VmG7AlISaD9fVfUjXl/e9MGA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QhpJ0IS9Xi4WA8tDCGDjmuGl4RbRMLkbljVoibHXe4xkdLkpCw82V9w0RY0iBkkQt xmS7qLK7h266d+PkrK3DphO5sBV6AYcKNIwYUmXqe1jgNPIPE1X/moMtOhcpvnuQPU 0aj1bB0SmuWL4i/Y1bMXcGXu3W7UXnsB9vR0+Qbc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbfHCHGy (ORCPT ); Sat, 3 Aug 2019 03:06:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:40672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727206AbfHCHGx (ORCPT ); Sat, 3 Aug 2019 03:06:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 756402173E; Sat, 3 Aug 2019 07:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564816011; bh=fAm+JJVlEEdZsZEnQU6VmG7AlISaD9fVfUjXl/e9MGA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EvBQbY6tUIAsZP4MFxGmLRqZJjlnz59fmNMbvE0jfno1B+JXE+PNryIyzSAnXbr8N +lgw4Y3y5zL8NJKrLYjFHjBcr6/6qlTB3yc6rbylv5fVS7aSSqYd41B1eBmWwcN4jJ e48QvmU3i/Btia6YyxF5rYYxbA6/qQXbJH8nGzR0= Date: Sat, 3 Aug 2019 09:06:40 +0200 From: Greg Kroah-Hartman To: john.hubbard@gmail.com Cc: Andrew Morton , linux-fbdev@vger.kernel.org, Jan Kara , kvm@vger.kernel.org, Dave Hansen , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, x86@kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , xen-devel@lists.xenproject.org, devel@lists.orangefs.org, linux-media@vger.kernel.org, Arnd Bergmann , "Guilherme G. Piccoli" , John Hubbard , intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , linux-rpi-kernel@lists.infradead.org, Dan Williams , linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, LKML , linux-xfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, Frank Haverkamp Subject: Re: [PATCH 10/34] genwqe: convert put_page() to put_user_page*() Message-ID: <20190803070640.GB2508@kroah.com> References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-11-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802022005.5117-11-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Aug 01, 2019 at 07:19:41PM -0700, john.hubbard@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > This changes the release code slightly, because each page slot in the > page_list[] array is no longer checked for NULL. However, that check > was wrong anyway, because the get_user_pages() pattern of usage here > never allowed for NULL entries within a range of pinned pages. > > Cc: Frank Haverkamp > Cc: "Guilherme G. Piccoli" > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Signed-off-by: John Hubbard > --- > drivers/misc/genwqe/card_utils.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) Acked-by: Greg Kroah-Hartman