From: Olga Kornievskaia <olga.kornievskaia@gmail.com> To: bfields@redhat.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH v5 0/9] server-side support for "inter" SSC copy Date: Thu, 8 Aug 2019 16:18:39 -0400 Message-ID: <20190808201848.36640-1-olga.kornievskaia@gmail.com> (raw) This patch series adds support for NFSv4.2 copy offload feature allowing copy between two different NFS servers. This functionality depends on the VFS ability to support generic copy_file_range() where a copy is done between an NFS file and a local file system. This is on top of Amir's VFS generic copy offload series. This feature is enabled by the kernel module parameter -- inter_copy_offload_enable -- and by default is disabled. There is also a kernel compile configuration of NFSD_V4_2_INTER_SSC that adds dependency on the NFS client side functions called from the server. These patches work on top of existing async intra copy offload patches. For the "inter" SSC, the implementation only supports asynchronous inter copy. On the source server, upon receiving a COPY_NOTIFY, it generate a unique stateid that's kept in the global list. Upon receiving a READ with a stateid, the code checks the normal list of open stateid and now additionally, it'll check the copy state list as well before deciding to either fail with BAD_STATEID or find one that matches. The stored stateid is only valid to be used for the first time with a choosen lease period (90s currently). When the source server received an OFFLOAD_CANCEL, it will remove the stateid from the global list. Otherwise, the copy stateid is removed upon the removal of its "parent" stateid (open/lock/delegation stateid). On the destination server, upon receiving a COPY request, the server establishes the necessary clientid/session with the source server. It calls into the NFS client code to establish the necessary open stateid, filehandle, file description (without doing an NFS open). Then the server calls into the copy_file_range() to preform the copy where the source file will issue NFS READs and then do local file system writes (this depends on the VFS ability to do cross device copy_file_range(). v5 fixes: -- Remove unused nl4_ulr/nl4_name types -- default to warn_on_once -- move 2 chucks of use of stid into previous patch -- in the idr store stateid ptr instead of copy or copy_notify -- add sc_type to distinguish copy and copy_notify stateid (for that need to re-work data structures to encapsulate stateid_t with sc_type) -- rework how initialization of copy and copy_notify stateid is done w respect to adding it to the global list -- during compound check to allow for stale_fh make sure that saved fh was set – done -- separated the copy_notify xdr code into its own patch -- need to insure the parent stateid is valid for copy_notify accesses. in preprocess_op take a reference on the parent stateid and hold it. on the put_stid, check if there are any copy_notifies associated and account for them during decrementing a reference count. add to the laundromat, traversing copy notify list of the client pointer, if entry is passed a lease period, then remove it. Olga Kornievskaia (9): NFSD fill-in netloc4 structure NFSD add ca_source_server<> to COPY NFSD return nfs4_stid in nfs4_preprocess_stateid_op NFSD COPY_NOTIFY xdr NFSD add COPY_NOTIFY operation NFSD check stateids against copy stateids NFSD generalize nfsd4_compound_state flag names NFSD: allow inter server COPY to have a STALE source server fh NFSD add nfs4 inter ssc to nfsd4_copy fs/nfsd/Kconfig | 10 ++ fs/nfsd/nfs4proc.c | 453 +++++++++++++++++++++++++++++++++++++++++++++++----- fs/nfsd/nfs4state.c | 179 ++++++++++++++++++--- fs/nfsd/nfs4xdr.c | 154 +++++++++++++++++- fs/nfsd/nfsd.h | 32 ++++ fs/nfsd/nfsfh.h | 5 +- fs/nfsd/nfssvc.c | 6 + fs/nfsd/state.h | 36 ++++- fs/nfsd/xdr4.h | 39 +++-- 9 files changed, 840 insertions(+), 74 deletions(-) -- 1.8.3.1
next reply index Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-08 20:18 Olga Kornievskaia [this message] 2019-08-08 20:18 ` [PATCH v5 1/9] NFSD fill-in netloc4 structure Olga Kornievskaia 2019-08-11 5:48 ` kbuild test robot 2019-08-12 16:12 ` Olga Kornievskaia 2019-08-12 19:58 ` J. Bruce Fields 2019-08-08 20:18 ` [PATCH v5 2/9] NFSD add ca_source_server<> to COPY Olga Kornievskaia 2019-08-11 5:59 ` kbuild test robot 2019-08-11 7:00 ` kbuild test robot 2019-08-08 20:18 ` [PATCH v5 3/9] NFSD return nfs4_stid in nfs4_preprocess_stateid_op Olga Kornievskaia 2019-08-08 20:18 ` [PATCH v5 4/9] NFSD COPY_NOTIFY xdr Olga Kornievskaia 2019-08-11 6:10 ` kbuild test robot 2019-08-08 20:18 ` [PATCH v5 5/9] NFSD add COPY_NOTIFY operation Olga Kornievskaia 2019-08-11 6:17 ` kbuild test robot 2019-08-12 16:19 ` Olga Kornievskaia 2019-08-12 19:16 ` Olga Kornievskaia 2019-08-12 20:00 ` J. Bruce Fields 2019-08-12 20:00 ` J. Bruce Fields 2019-08-13 17:57 ` Olga Kornievskaia 2019-08-14 15:05 ` Olga Kornievskaia 2019-08-29 19:23 ` Olga Kornievskaia 2019-08-30 17:56 ` J. Bruce Fields 2019-08-08 20:18 ` [PATCH v5 6/9] NFSD check stateids against copy stateids Olga Kornievskaia 2019-08-08 20:18 ` [PATCH v5 7/9] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia 2019-08-08 20:18 ` [PATCH v5 8/9] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia 2019-08-08 20:18 ` [PATCH v5 9/9] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia 2019-08-11 6:24 ` kbuild test robot 2019-09-04 20:50 ` [PATCH v5 0/9] server-side support for "inter" SSC copy J. Bruce Fields 2019-09-05 0:05 ` Olga Kornievskaia 2019-09-05 0:13 ` Rick Macklem 2019-09-06 14:23 ` Olga Kornievskaia 2019-09-06 15:32 ` Rick Macklem
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190808201848.36640-1-olga.kornievskaia@gmail.com \ --to=olga.kornievskaia@gmail.com \ --cc=bfields@redhat.com \ --cc=linux-nfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nfs/0 linux-nfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nfs linux-nfs/ https://lore.kernel.org/linux-nfs \ linux-nfs@vger.kernel.org public-inbox-index linux-nfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-nfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git