From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE5BC32750 for ; Wed, 14 Aug 2019 02:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED1BF20874 for ; Wed, 14 Aug 2019 02:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565750113; bh=QDA+wZbqL00DcUe7rHsoYGH18rcg7ZtglEbJHTJC1gQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RY9c5E8EB2p6kbqgZOfM6KL37wtEEyniRLbjmxliArGhbK8fD0EkCvmiRHPIFUTRq vkhF+ggCZ7w4OeMOzIjkvkGiFOz63gK4oiU/je1oHhL1DhPnPLhDyImKyCNImzkAYi +XkyYFOOwJN/jbfqHRs2k2sqmG2zec/fmZlf7M4s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbfHNCfM (ORCPT ); Tue, 13 Aug 2019 22:35:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:45692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbfHNCNk (ORCPT ); Tue, 13 Aug 2019 22:13:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57CC321721; Wed, 14 Aug 2019 02:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565748819; bh=QDA+wZbqL00DcUe7rHsoYGH18rcg7ZtglEbJHTJC1gQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z1vnBWQqBYS01jtKAmZ1w3WUDtTi1yj/8ZcYxilOwx9Zn6cqXMFCQrKOiDVjlW/sZ /hE1vFjcy2ka4m46fXR8e3AauodPPDuYdP8tB9qjDTwWaJmo4o3sJKI/uyFOxrwaQU dB8yzs0czOglnd/OAbm5KT2O3rtdCiibKsz/t3IM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Trond Myklebust , Sasha Levin , linux-nfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 080/123] NFSv4: Fix a credential refcount leak in nfs41_check_delegation_stateid Date: Tue, 13 Aug 2019 22:10:04 -0400 Message-Id: <20190814021047.14828-80-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190814021047.14828-1-sashal@kernel.org> References: <20190814021047.14828-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust [ Upstream commit 8c39a39e28b86a4021d9be314ce01019bafa5fdc ] It is unsafe to dereference delegation outside the rcu lock, and in any case, the refcount is guaranteed held if cred is non-zero. Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs4proc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 6418cb6c079bd..11a5aa46e64c3 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2749,8 +2749,7 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state) if (status == -NFS4ERR_EXPIRED || status == -NFS4ERR_BAD_STATEID) nfs_finish_clear_delegation_stateid(state, &stateid); - if (delegation->cred) - put_cred(cred); + put_cred(cred); } /** -- 2.20.1