From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B76BC3A5A8 for ; Wed, 4 Sep 2019 16:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53B6020820 for ; Wed, 4 Sep 2019 16:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567613264; bh=mj3U4sRDS8aeanAqrXJcjO6Wq6Bt5NxJ+ZBR9ABdTa0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Wq6AKD8Z2AqzdybyK4HELDWAjDw67rKaY1TFqYngOqv7qFbuHQOb819gYU9491IzR 5AmS4A+r4bW9k7+eniAnrrruw2LDShilk1MYQrt4tETuX5dEzBwK9K8zWq6ZRClXKb bDjxvFX6g58yKNoKqR6uVuHUPi9sAJXjZu92ir+w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730217AbfIDQHi (ORCPT ); Wed, 4 Sep 2019 12:07:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733132AbfIDQBz (ORCPT ); Wed, 4 Sep 2019 12:01:55 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A11E23401; Wed, 4 Sep 2019 16:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567612914; bh=mj3U4sRDS8aeanAqrXJcjO6Wq6Bt5NxJ+ZBR9ABdTa0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PzK9T+/rc7KvcEH8TA6KM4O7P/sqRcngh1F/SIbIaniJVFiFshohVAojJ0FclH4Z4 fFiWQrtZJ7tp7C8xSSA/nbXOLf4Hoibj9EeAoAyaQBHsmkn5vpjrs/UXKBIv59tlyS AERY4/KTGAt3VuDsZX43FwcIBi62wV46h7j7CJgA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Trond Myklebust , Jan Stancek , Naresh Kamboju , Sasha Levin , linux-nfs@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 21/36] NFSv2: Fix write regression Date: Wed, 4 Sep 2019 12:01:07 -0400 Message-Id: <20190904160122.4179-21-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190904160122.4179-1-sashal@kernel.org> References: <20190904160122.4179-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index 73d1f7277e482..eff93315572e7 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -611,8 +611,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1